make test: Fix mocha timeout @ 'Plural Forms Parsing should have the sam... #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…same result as doing an eval on the expression for all known plural-forms'
|
So nice. Thank you. |
SlexAxton
added a commit
that referenced
this pull request
Sep 17, 2014
make test: Fix mocha timeout @ 'Plural Forms Parsing should have the sam...
|
Thank you, it's a really cool project. |
|
I always have to make sure you know about https://github.com/SlexAxton/messageformat.js -- which is what I generally suggest to people unless they're already using gettext in other systems. |
|
Yeah I see, it uses PluralFormat/SelectFormat. I think for my current project it's a priority that there are tools for OS X and Windows that non-technical folks can easily use. A friend told me that there are even web apps for that, but I guess that's all gettext/.po editors. |
|
Yep, makes sense. Hopefully we can fix the tooling problem in the next few years, because it's a really nice upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
With this fix
make testis error free! My Mac needs 6 seconds with the current HEAD, Travis CI needs 3 seconds. This patched version is a bit less than 1 second on my Mac, so it should be half a second on Travis CI which is way less than mocha's default timeout of 2 seconds...expect.js's
beandtofunctions aren't really complex but heavy enough to be more than 6x slower than a simple!==+throw.Cheers, Philip