Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme says that Jed ignores the first element of the translated array, but that's no longer the case. #35

Closed
emosesSfdc opened this issue Nov 11, 2014 · 5 comments

Comments

@emosesSfdc
Copy link

In commit 8cc3736, it looks like the expected format of locale_data changed so that the first element of the translated data array is no longer supposed to be a null. That's at odds with what's on the doc site http://slexaxton.github.io/Jed/ and a lot of the examples on the web. po2json, which I was using to parse my po files, doesn't output the right format anymore. Please update the doc and examples.

@SlexAxton
Copy link
Member

I think that commit fixes that. Let me know if you see something I got wrong.

@emosesSfdc
Copy link
Author

I think that fixes the doc, thanks.

On Tue, Nov 11, 2014 at 1:25 PM, Alex Sexton notifications@github.com
wrote:

I think that commit fixes that. Let me know if you see something I got
wrong.


Reply to this email directly or view it on GitHub
#35 (comment).

Evan Moses
emoses@salesforce.com

@emosesSfdc
Copy link
Author

Thanks for the quick response, by the way.

On Tue, Nov 11, 2014 at 1:27 PM, Evan Moses emoses@salesforce.com wrote:

I think that fixes the doc, thanks.

On Tue, Nov 11, 2014 at 1:25 PM, Alex Sexton notifications@github.com
wrote:

I think that commit fixes that. Let me know if you see something I got
wrong.


Reply to this email directly or view it on GitHub
#35 (comment).

Evan Moses
emoses@salesforce.com

Evan Moses
emoses@salesforce.com

@emosesSfdc
Copy link
Author

Hi again, Alex (cc Mike Edwards, maintainer of po2json),

So, I just started working with Jed this week, and one of the tools I
was using per the recommendation of some website I stumbled across is
po2json. It hadn't been updated for 1.1 with the new format, but it's
author and I were trying to puzzle out exactly what plural forms should
look like. Would you mind taking a look at this pull request? Also, please
forgive my lack of knowledge of either version, I'm not really sure how
things are supposed to look since I've never actually used this stuff
before.

https://github.com/mikeedwards/po2json/pull/32/files#r20185280

The problem is that a plural form used to look like:

"%d shirt": [
"%d shirts",
"una camisa",
"%d camsias"]

with the plural key in the value array, and now we're not sure what it
should look like. Is it like this?

"%d shirt": ["una camisa"]

"%d shirts": ["una camisa", "%d camisas"]

On Tue, Nov 11, 2014 at 1:41 PM, Evan Moses emoses@salesforce.com wrote:

Thanks for the quick response, by the way.

On Tue, Nov 11, 2014 at 1:27 PM, Evan Moses emoses@salesforce.com wrote:

I think that fixes the doc, thanks.

On Tue, Nov 11, 2014 at 1:25 PM, Alex Sexton notifications@github.com
wrote:

I think that commit fixes that. Let me know if you see something I got
wrong.


Reply to this email directly or view it on GitHub
#35 (comment).

Evan Moses
emoses@salesforce.com

Evan Moses
emoses@salesforce.com

Evan Moses
emoses@salesforce.com

@SlexAxton
Copy link
Member

Merging this with #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants