Skip to content

Commit

Permalink
COMP: Update DCMTK to fix CMP0115 CMake warnings
Browse files Browse the repository at this point in the history
List of changes:

$ git shortlog f2f7b5ee0..0f9bf4d9e --no-merges
Marco Eichelberg (1):
      [Backport] Made file extensions explicit for CMake CMP0115.

This commit fixes warning like the following:

  CMake Warning (dev) at CMake/dcmtkMacros.cmake:82 (add_library):
    Policy CMP0115 is not set: Source file extensions must be explicit.  Run
    "cmake --help-policy CMP0115" for policy details.  Use the cmake_policy
    command to set the policy and suppress this warning.

    File:

      /path/to/S-r/DCMTK/oflog/libsrc/nullap.cc
  Call Stack (most recent call first):
    oflog/libsrc/CMakeLists.txt:10 (DCMTK_ADD_LIBRARY)
  • Loading branch information
jcfr committed Nov 5, 2021
1 parent fb1f7cb commit 3eb2c42
Showing 1 changed file with 12 additions and 5 deletions.
17 changes: 12 additions & 5 deletions SuperBuild/External_DCMTK.cmake
Expand Up @@ -56,11 +56,18 @@ if(NOT DEFINED DCMTK_DIR AND NOT Slicer_USE_SYSTEM_${proj})

ExternalProject_SetIfNotDefined(
Slicer_${proj}_GIT_TAG
# Official DCMTK release DCMTK-3.6.6
# https://git.dcmtk.org/?p=dcmtk.git;a=commit;h=6cb30bd7fb42190e0188afbd8cb961c62a6fb9c9
# with an extra backported patch
# https://git.dcmtk.org/?p=dcmtk.git;a=commit;h=b665e2ec2d5ce435e28da6c938736dcfa84d0da6
"patched-DCMTK-3.6.6_20210115"
# Based of the official DCMTK release DCMTK-3.6.6
# * https://github.com/DCMTK/dcmtk/commit/6cb30bd7fb42190e0188afbd8cb961c62a6fb9c9
# * https://github.com/DCMTK/dcmtk/releases/tag/DCMTK-3.6.6
#
# with these backported patches:
# * Fixed extra padding created for some segmentations.
# https://github.com/DCMTK/dcmtk/commit/b665e2ec2d5ce435e28da6c938736dcfa84d0da6
#
# * Made file extensions explicit for CMake CMP0115
# https://github.com/DCMTK/dcmtk/commit/d090b6d7c65e52e01e436a2473dc8ba3f384efbb
#
"0f9bf4d9e9a778c11fdddafca691b451c2b621bc" # patched-DCMTK-3.6.6_20210115
QUIET
)

Expand Down

0 comments on commit 3eb2c42

Please sign in to comment.