New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support adjusting the Thick Slab Reconstruction (TSR) thickness directly from slice views #7083
Comments
The current behavior doesn't look too bad to me. |
Is the center (non-slab) intersection necessary when viewing the slab? If not then just having the 2 yellow lines seems to make more sense then the 3 yellow lines. Otherwise the "thick slab" lines being some X number of pixels thicker than the regular slice intersection current thickness could help identify them as being something different. |
Until we can have dashed line working, that seems like a sensible path forward. |
Thanks all for the responses.
If I'm understanding correctly, the user wouldn't be able to adjust the slab thickness and interactively move the slice at the same time. They'd need to remove the TSR, move the slice, then re-enable the TSR. This might make sense anyway, since when I add interactivity, the handles for moving the slice / the handles for adjusting the thick slab lines might overlap a bit. If you don't mind this toggling on / off, I can remove the center line when TSR is enabled. Just wanted to point this out! |
What about updating the following: to include:
That way the user decide if both This means would have to introduce an additional property to toggle TSR interactivity. |
That would work for the "interactive" slice view lines, but we also display the lines when the "interactive" option is unchecked in the slice view widget. Another option is to do what @jamesobutler was saying (erase the middle line if the slab reconstruction is on), and when the user moves either of those two lines, the behavior is the same as interacting with the previously shown middle line (just changes the slice). But if the user checks the interactive option for the TSR that @jcfr proposed, interacting with those two lines changes the thickness of the thick slab. Whatever you all prefer! |
@jcfr and I just got off a call discussing this. In short, the TSR options and the slice intersection options are going to be totally independent / in separate UI elements. All TSR options are going to be in the dropdown menu for each slice view (see below), instead of in the slice intersection widget. I'll add another option
to the menu This includes options for toggling the display and interactivity. The slice intersection widget will only contain options for the slice intersection interactivity / display. Thanks everyone for the input. |
Is your feature request related to a problem? Please describe.
Support adjusting slab reconstruction thickness directly from the slice views.
Describe the solution you'd like
vtkMRMLSlabReconstructionDisplayableManager
Describe alternatives you've considered
NA
Additional context
Originally posted by @jamesobutler in #6965 (comment)
cc: @lassoan
The text was updated successfully, but these errors were encountered: