Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unused variable in vtkMRMLNode.cxx #7725

Closed
maddin200 opened this issue May 3, 2024 · 2 comments · Fixed by #7739
Closed

unused variable in vtkMRMLNode.cxx #7725

maddin200 opened this issue May 3, 2024 · 2 comments · Fixed by #7739

Comments

@maddin200
Copy link
Contributor

Libs\MRML\Core\vtkMRMLNode.cxx line 517
Code:
//write node references
std::stringstream ssRef;
NodeReferencesType::iterator it;
std::map< std::string, std::string>::iterator itName; // <- unused
@lassoan
Copy link
Contributor

lassoan commented May 10, 2024

Thank you for pointing this out. It would be awesome if you could send a pull request, but if that's not feasible then we'll get to work on it later.

@jcfr jcfr linked a pull request May 14, 2024 that will close this issue
BUG: Update vtkMRMLNode.cxx remove unused variable #7739
Merged
@jcfr jcfr changed the title unused variable unused variable in vtkMRMLNode.cxx May 14, 2024
@jcfr
Copy link
Member

jcfr commented May 14, 2024

Slicer/Libs/MRML/Core/vtkMRMLNode.cxx

Lines 514 to 527 in 3802d81

//write node references
std::stringstream ssRef;
NodeReferencesType::iterator it;
std::map< std::string, std::string>::iterator itName;
for (it = this->NodeReferences.begin(); it != this->NodeReferences.end(); it++)
{
const std::string& referenceRole = it->first;
int numReferencedNodes = this->GetNumberOfNodeReferences(referenceRole.c_str());
bool referenceFound = false;
for (int n=0; n < numReferencedNodes; n++)
{
const char * id = this->GetNthNodeReferenceID(referenceRole.c_str(), n);
if (!id)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BUG: Update vtkMRMLNode.cxx remove unused variable maddin200/Slicer
3 participants
@jcfr @lassoan @maddin200