Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tool to assign series to a PI-RADS MRI type into an SR document #2

Open
fedorov opened this issue Mar 19, 2018 · 7 comments
Open
Assignees

Comments

@fedorov
Copy link
Member

fedorov commented Mar 19, 2018

No description provided.

@fedorov fedorov changed the title Add Add a tool to assign series to a PI-RADS MRI type into an SR document Mar 19, 2018
@fedorov fedorov self-assigned this Mar 19, 2018
@fedorov
Copy link
Member Author

fedorov commented Mar 22, 2018

functional dcmqi tool in this branch: https://github.com/fedorov/dcmqi/tree/qiicrx

@che85
Copy link
Member

che85 commented Mar 28, 2018

slicer.modules.qiicrx-sr is not callable from python scripting.

>>> slicer.modules.qiicrx-sr
Traceback (most recent call last):
  File "<console>", line 1, in <module>
AttributeError: 'module' object has no attribute 'qiicrx'

after renaming it to slicer.modules.qiicrx_sr it works:

>>> slicer.modules.qiicrx_sr
qSlicerCLIModule (qSlicerCLIModule at: 0x7fe72b067350)

@jcfr Are there any such restrictions of not using - in cli module names? The xml-generated 3DSlicer ui works without issues.

@jcfr
Copy link

jcfr commented Mar 28, 2018

- is forbidden in python identifier names

See https://docs.python.org/2/reference/lexical_analysis.html#identifiers

We could also systematically convert - to _ when doing the module discovery but I suggest to keep things consistent.

https://stackoverflow.com/questions/761519/is-it-ok-to-use-dashes-in-python-files-when-trying-to-import-them

@fedorov
Copy link
Member Author

fedorov commented Mar 28, 2018

I anticipated this would cause problems. Let's just rename the converter to qiicrxSR or something like that.

@che85 che85 added this to the First Prototype milestone Apr 4, 2018
@fedorov
Copy link
Member Author

fedorov commented Apr 20, 2018

@che85 there should also be a way to manually assign series type by the operator, in case automatic detection failed. There are different ways automatic assignment can fail - it can assign a wrong category, or it can completely miss certain series. What this means is that there should also be a way to add manually individual series from the study and assign series type.

@che85
Copy link
Member

che85 commented Apr 20, 2018

We should talk about how to do that in the user interface.

@fedorov
Copy link
Member Author

fedorov commented Apr 20, 2018

I was adding form content in the google doc, and I was thinking perhaps this could be done in the "study assessment" form - check it out here. Let's discuss when you are back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants