Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

By restarting PBRcontrol we lose information #11

Open
xtrojak opened this issue Oct 25, 2019 · 2 comments
Open

By restarting PBRcontrol we lose information #11

xtrojak opened this issue Oct 25, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@xtrojak
Copy link
Collaborator

xtrojak commented Oct 25, 2019

I'm not sure whether this is critical, so it has probably low priority.

Anyway... in case we restart the PBRcontrol, it automatically loses information about which data have already been checked. It is natural since this information is only stored "in code" when it is running. Then when get_log is called again, all available data from DB are provided.

This could be solved in two ways:

  1. the information is stored in DB
  2. it could be solved on Bioarineo side - when connection stops working I will remember the last time stamp when I obtained some data, if I reconnect I will call get_log with the time stamp.

For solution 2, however, we would need some "ping" function which I could use to check whether the PBRcontrol is accessible again (pinging the server is not enough, it does not imply the tool is running too).

Any other ideas or preferences?

@xtrojak xtrojak added the enhancement New feature or request label Oct 25, 2019
@DanDayne
Copy link
Collaborator

The ping function would certainly be useful, I will get right on it in #12 .

Another option would be for PBRcontrol to store this information in the separate config.json file that was created as means to resolve issue #7

@DanDayne
Copy link
Collaborator

Ping method is partially implemented and is ready to be used in solution 2. (#12 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants