Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with Brave 5.x #28

Open
b-devinssuresh-cvet opened this issue Feb 22, 2019 · 4 comments
Open

Not compatible with Brave 5.x #28

b-devinssuresh-cvet opened this issue Feb 22, 2019 · 4 comments

Comments

@b-devinssuresh-cvet
Copy link

b-devinssuresh-cvet commented Feb 22, 2019

When trying to use smartthings-brave-sqs in a sleuth app I ran into a compatibility issue:

ava.lang.NoSuchMethodError: brave.Tracer.newTrace(Lbrave/propagation/SamplingFlags;)Lbrave/Span;
	at smartthings.brave.sqs.TracingAmazonSQSClient.receiveMessage(TracingAmazonSQSClient.java:251) ~[smartthings-brave-sqs-0.5.1.jar:na]
	at com.amazon.sqs.javamessaging.AmazonSQSMessagingClientWrapper.receiveMessage(AmazonSQSMessagingClientWrapper.java:351) ~[amazon-sqs-java-messaging-lib-1.0.5.jar:na]
	at com.amazon.sqs.javamessaging.SQSMessageConsumerPrefetch.getMessages(SQSMessageConsumerPrefetch.java:262) ~[amazon-sqs-java-messaging-lib-1.0.5.jar:na]
	at com.amazon.sqs.javamessaging.SQSMessageConsumerPrefetch.run(SQSMessageConsumerPrefetch.java:221) ~[amazon-sqs-java-messaging-lib-1.0.5.jar:na]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [na:1.8.0_192]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [na:1.8.0_192]
	at java.lang.Thread.run(Thread.java:748) [na:1.8.0_192]

Are there plans to update? Or are you open to updating if I file a PR?

@llinder
Copy link
Contributor

llinder commented Feb 22, 2019

There isn't any work underway to fix this yet. I'm sure if/when we hit this it will get fixed. In the mean time if you or anyone else has bandwidth to make a pull request it would definitely be appreciated and gladly accepted.

@llinder
Copy link
Contributor

llinder commented Feb 22, 2019

I'm also open to moving the SQS part or other parts of this library to openzipkin-contrib or openzipkin/zipkin-aws. Not to say that should happen now but just mentioning in case it's a desirable path for anyone.

@YasinK-IW
Copy link

This would be a massive help if it worked with Brave 5.x :)

@devinsba
Copy link

I started the update: #29

I think the SQS/SNS pieces we should discuss on dev@zipkin.apache.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants