Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPC Text Animation "animated talking" doesn't parse some rich text #4428

Closed
MoltonMontro opened this issue Apr 17, 2024 · 2 comments
Closed

Comments

@MoltonMontro
Copy link
Member

MoltonMontro commented Apr 17, 2024

Crosspost of the "[Bug] NPC Rich Text Modifiers Half Working" forum topic.

The "animated talking" setting doesn't work with dialogue using rich text as expected. Some properties seem to be parsed (e.g., <color> and <size>) but aren't always removed from the text. Other properties like <align> aren't parsed at all.

Example: <align=center><size=150%><color=blue>Ah, welcome, welcome</color></size></align=center> (closing tags optional).

image

@SDGNelson
Copy link
Member

Oops I saw that post and meant to double-check, thanks. I think we currently have a few hardcoded tags supported. :S

@SDGNelson
Copy link
Member

Thankfully this turned out to be a relatively straightforward issue! It didn't properly remove the opening tags if the first character of the message was '<'.

@SDGNelson SDGNelson added the Resolved but not on preview branch yet Noted as not "to-do" anymore. label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants