Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 introduces dependency on Smile_Elasticsuite* #93

Closed
fnogatz opened this issue Mar 20, 2020 · 3 comments
Closed

v2 introduces dependency on Smile_Elasticsuite* #93

fnogatz opened this issue Mar 20, 2020 · 3 comments
Assignees

Comments

@fnogatz
Copy link

fnogatz commented Mar 20, 2020

As of version 1.x, it was possible to use this module stand-alone. With v2, the autocomplete feature introduces a dependency on some Smile_Elasticsuite* components, as in, e.g., class Smile\StoreLocator\Model\Autocomplete\Data, which uses Smile\ElasticsuiteCore\Helper\Autocomplete and Smile\ElasticsuiteRetailer\Model\ResourceModel\Fulltext\CollectionFactory. This dependency is not reflected in composer.json.

Any chance to keep the separation as in v1.x? We would like to keep using Smile_StoreLocator with the ability to upgrade to v2 at some point :)

@Fdec
Copy link
Contributor

Fdec commented Mar 23, 2020

Hi @fnogatz

Indeed, I will try to find a solution.

stay tuned.

@romainruaud
Copy link
Contributor

As discussed, everything related to search and/or autocompletion should be put in this module instead of here : https://github.com/Smile-SA/magento2-module-retailer-elasticsuite-search

@Fdec can you also put somewhere in the documentation that this module exists ? :)

Regards

@Fdec
Copy link
Contributor

Fdec commented Mar 27, 2020

Hi @fnogatz

It's fixed. You can update to 2.0.2 release.
Thanks for the report !

Fanny

@Fdec Fdec closed this as completed Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants