Countries.__iter__ very slow in Django admin #454
Comments
|
Timing the list of countries still wouldn't be triggering the translations of the lazy strings. You'd probably need to time something like |
|
Thanks for your reply. I've investigated a bit more, and I've found that the slowness I observe may have to do with the fact that the Countries.__iter__() method is being called many times, and not with a single call being particularly slow. My testing in the Python interpreter did not reflect that and called it only once, and is thus not realistic. With the CountryField in list_display, I observe that the Countries.__iter__() method is called twice as many times as the number of instances displayed in the admin changelist view. I've seen this by putting a breakpoint at the start of the __iter__ method, and I got the following stack trace (many times): It seems Django calls display_for_field for every instance in the changelist, which calls _get_flatchoices, which iterates over all choices provided by Countries.__iter__(). The choices are translated and sorted every time in Countries.__iter__(). It would be great if it would be possible to cache the result. |
|
Just as an additional data point, if I make a crude custom CountryField like this: class CachingCountryField(CountryField):
def __init__(self, *args, **kwargs):
super().__init__(self, *args, **kwargs)
self.choices = list(self.choices)With this, the page rendering time for the changelist view in my development server goes down from +-10.000 ms to +-450ms. Obviously this is not a real solution. But I think it shows that caching would be worthwhile. |
|
Thanks for your findings! I'll take another dive into why this is happening soon. Caching would be a potential way to bandaid fix this and probably a good efficiency improvement anyway, however the caching does need to take into account the current active translation and not just hard code the list (hence why it's being done lazily currently) |
I see a strange performance issue with django-countries 7.5.1. I'm using Django 4.2.8, I have USE_I18N on and I do not have pyuca installed.
In my app there's a django model with a CountryField. Its admin page includes the country field in list_display and list_filter. For some reason, rendering the changelist page takes upward of 6-7 seconds (on a Ryzen 9 5900X CPU). If I remove the country field from list_display and list_filter, the same list renders in around 300ms. This is all with DEBUG on, on the regular development runserver.
I've done a bit of profiling, and found that it seems to be Countries.__iter__ which is slow. I'm not sure how to share the profiling data, so here's a screenshot of a flame graph:
Please note that according to the profiler, the top entry for Countries.__iter__ in the flamegraph above corresponds to an execution time of +- 3.4 seconds.
For verification I tried listing the countries in a Python shell (shell_plus from django-extensions) instead, and there the slowdown doesn't happen:
So this indicates to me that there may be a problem having to do with my Django configuration, in particular wrt. translations. But I haven't managed to find out more yet.
I'd be grateful for any help with this issue.
The text was updated successfully, but these errors were encountered: