Parameter 'quality' is not passed to pillow if WEBP format is used #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wouldn't it be better to rewrite line 53 to |
|
JPEG branch has some specific JPEG handling code, for example conversion from RGBA to RGB because jpeg don't support alpha, but webp can store alpha. |
This will pass quantity to other formats like WEBP
|
My updated pull request removes quantity option only for TIFF format. I think, this is best solution for now. |
jrief
approved these changes
Jan 5, 2023
|
Please read my follow-up comment on this. GitHub changed something in their action scripts, which causes the unit tests to fail. |
|
Can you please retry with version 2.8.5. This should fix the regression introduced in 2.8.4. |
|
It's OK now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After commit 7b9719e, parameter 'quality' is not passed to pillow for any format except of 'JPEG'.