Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict between RtcClass and RBoot RTC data #699

Closed
capablegh opened this issue Apr 15, 2016 · 2 comments
Closed

Conflict between RtcClass and RBoot RTC data #699

capablegh opened this issue Apr 15, 2016 · 2 comments

Comments

@capablegh
Copy link

File 'Sming/SmingCore/Platform/RTC.h' defines RTC_DES_ADDR as 64, the address for 'RtcData'. And file 'Sming/rboot/rboot.h' defines RBOOT_RTC_ADDR also as 64 for 'rboot_rtc_data' when BOOT_RTC_ENABLED is defined. Noted in Git commit '49f786e35f5c35305b97d43165cdd97ec8c36cc5'

Opening request per http://www.esp8266.com/viewtopic.php?f=35&t=9532#p45515

@raburton
Copy link
Member

raburton commented Apr 15, 2016

You can change one of these values to use both at once (the rBoot one is not enabled by default), but there does need to be a better system here. Possibly just allowing one or the other to be overridden with a define in the CFLAGS to enable to user to decide where to put it. It'd be easier to make the overridable one the RTC class because once the rBoot one is deployed in the bootloader it needs to stay the same in the API.

@hreintke
Copy link
Contributor

Will not be updated in SmingNONOS.
If issue still exists, open an issue in SmingRTOS

@hreintke hreintke removed the Review label May 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants