Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use views instead of owned arrays where possible #51

Closed
BTOdell opened this issue Apr 22, 2024 · 4 comments
Closed

Use views instead of owned arrays where possible #51

BTOdell opened this issue Apr 22, 2024 · 4 comments
Assignees

Comments

@BTOdell
Copy link
Contributor

BTOdell commented Apr 22, 2024

Many of the functions in this library require owned arrays to be passed: https://github.com/Smirkey/powerboxes/blob/main/powerboxesrs/src/nms.rs#L32

The algorithm eventually makes a copy of the data anyway, so it would be more efficient to only require views to be passed as input.

@Smirkey
Copy link
Owner

Smirkey commented Apr 23, 2024

Some very good advice thanks :)
I will look into it

@BTOdell
Copy link
Contributor Author

BTOdell commented Apr 23, 2024

I applied these recommendations (along with some others) to my own fork: #52

Note that these are breaking changes.

@Smirkey
Copy link
Owner

Smirkey commented Apr 24, 2024

great thanks !!

@Smirkey
Copy link
Owner

Smirkey commented Apr 30, 2024

solved by #53

@Smirkey Smirkey closed this as completed Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants