Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple single core test failures on python3.8: FAILED (failures=1, errors=69, skipped=101) #57

Closed
sanjayankur31 opened this issue May 22, 2020 · 7 comments

Comments

@sanjayankur31
Copy link
Contributor

These are the only ones I've run here:

  • clone the repo
  • set up a new virtual environment, pew new pypet
  • python setup.py install
  • python pypet/tests/all_single_core_tests.py

The output is attached. There are multiple failures:
test-log.txt

@SmokinCaterpillar
Copy link
Owner

Thanks, yes pypet needs some updates regarding newer pandas and python versions. @caglorithm do you want to look at it? I'm currently short on time (Maybe I can look at it next week for a bit).

@SmokinCaterpillar
Copy link
Owner

ok, I'm currently fixing it, there were only some minor issues with pandas

  • HDFStore no longer supportin filters
  • as_matrix has been removed and one simply needs to use values.

New version should be available soon.

@SmokinCaterpillar
Copy link
Owner

@sanjayankur31 can you install pypet 0.5.0 and rerun the tests?

@sanjayankur31
Copy link
Contributor Author

Looks pretty good! Only 5 tests were skipped, the rest look fine. Complete log attached.
pypet-fedora-py3.8.3-tests.txt

These are the dependency versions I'd run them with:

$ rpm -qa \*scipy\* \*brian2\* \*numpy\* \*hdf5\* \*pandas\* \*tables\*


python3-scipy-1.4.1-1.fc32.x86_64
python3-numpy-f2py-1.18.4-2.fc32.x86_64
python3-pandas-0.25.3-2.fc32.x86_64
hdf5-1.10.5-6.fc32.x86_64
python3-pandas-datareader-0.8.0-2.fc32.noarch
python3-brian2-2.3.0.2-1.fc32.x86_64
python3-numpy-1.18.4-2.fc32.x86_64
python3-tables-3.5.2-7.fc32.x86_64

$ python --version
Python 3.8.3

Fedora 33 now has Python 3.9, so I'll be able to report back once I've kicked off a build for that in a bit.

@sanjayankur31
Copy link
Contributor Author

Also look good with Python3.9 on F33. Logs attached:

pypet-python3.9-buildlog.txt
pypet-python3.9-rootlog.txt

Package versions here:

python3-numpy-f2py-1:1.18.4-3.fc33.x86_64
python3-numpy-1:1.18.4-3.fc33.x86_64
python3-scipy-1.4.1-2.fc33.x86_64
python3-pandas-1.0.1-2.fc33.x86_64
python3-tables-3.5.2-8.fc33.x86_64
python3-brian2-2.3.0.2-2.fc33.x86_64

I've updated the Fedora packages to 0.5.0 now. That'll also run the builds on various other architectures. If something untoward happens, I'll report back.

Thanks very much for looking into this so quickly.

@SmokinCaterpillar
Copy link
Owner

I'll do another 0.5.1 release today, this won't change anything in comparison to 0.5.0 except for some corrections in the docs and the readme

@SmokinCaterpillar
Copy link
Owner

0.5.1 is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants