Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor : Remove on_gcode_execute #82

Closed
arthurwolf opened this issue Jan 15, 2013 · 1 comment
Closed

Refactor : Remove on_gcode_execute #82

arthurwolf opened this issue Jan 15, 2013 · 1 comment

Comments

@arthurwolf
Copy link
Contributor

Planned refactor.

We would stop storing gcodes amongst with blocks. Instead, modules would read gcodes in on_gcode_received, transform those into a ModuleData storage thingie, that would be attached to blocks.

class ModuleData { Module* owner; }; .... class TemperatureControlBlob : public ModuleData { ... }; .... class Block { ... vector or whatever <ModuleData*> data; }

@wolfmanjm
Copy link
Contributor

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants