Masonry is malfunctioning in iOS 10 while compiling with XCode 8. #382

aquaibm · 2016-09-14T11:54:38Z

It worked well before I updated to iOS 10 and Xcode 8.
For example,in a UITableViewCell subclass:

        UIImageView *imageView = [UIImageView new];
        imageView.contentMode = UIViewContentModeScaleAspectFill;
        [self.contentView addSubview: imageView];
        self.contentView.translatesAutoresizingMaskIntoConstraints = NO;
        [imageView mas_makeConstraints:^(MASConstraintMaker *make) {
            make.left.mas_equalTo(0);
            make.right.mas_equalTo(0);
            make.top.mas_equalTo(15);
            make.height.mas_equalTo(imageView.mas_width).with.multipliedBy(9/16.0);
        }];
        self.pImageView = imageView;

        [self.contentView mas_makeConstraints:^(MASConstraintMaker *make) {
            make.left.mas_equalTo(0);
            make.right.mas_equalTo(0);
            make.top.mas_equalTo(0);
            make.bottom.mas_equalTo(imageView.mas_bottom).with.offset(15);
        }];

This used to work like a charm in iOS 9 while compiling with XCode 7.x, but now it is not.
Console shows this:

[LayoutConstraints] Unable to simultaneously satisfy constraints.
    Probably at least one of the constraints in the following list is one you don't want. 
    Try this: 
        (1) look at each constraint and try to figure out which you don't expect; 
        (2) find the code that added the unwanted constraint or constraints and fix it. 
(
    "<MASLayoutConstraint:0x1740b1dc0 UITableViewCellContentView:0x100546830.bottom == UIImageView:0x1005203b0.bottom + 15>",
    "<MASLayoutConstraint:0x1740b2120 UIImageView:0x1005203b0.left == UITableViewCellContentView:0x100546830.left>",
    "<MASLayoutConstraint:0x1740b2180 UIImageView:0x1005203b0.right == UITableViewCellContentView:0x100546830.right>",
    "<MASLayoutConstraint:0x1740b2240 UIImageView:0x1005203b0.top == UITableViewCellContentView:0x100546830.top + 15>",
    "<MASLayoutConstraint:0x1740b2300 UIImageView:0x1005203b0.height == UIImageView:0x1005203b0.width * 0.5625>",
    "<NSLayoutConstraint:0x174099eb0 UITableViewCellContentView:0x100546830.height == 0>",
    "<NSLayoutConstraint:0x174099e60 UITableViewCellContentView:0x100546830.width == 375>"
)

Will attempt to recover by breaking constraint 
<MASLayoutConstraint:0x1740b2300 UIImageView:0x1005203b0.height == UIImageView:0x1005203b0.width * 0.5625>

How can I fix this? Thanks a lot.

The text was updated successfully, but these errors were encountered:

robertjpayne · 2016-09-14T12:00:30Z

@aquaibm are you using interface builder at all?

Looks like iOS 10 has two additional constraints there for width/height unsure why but that's whats causing the error.

aquaibm · 2016-09-14T12:07:04Z

No, I am not using interface builder, purely code layout,NO xib file for this class.

robertjpayne · 2016-09-14T12:07:56Z

@aquaibm what if you do self.translatesAutoresizingMaskIntoConstraints = NO as well? And are you using iOS's prefetching or auto cell sizing?

robertjpayne · 2016-09-14T12:09:05Z

@aquaibm basically something in iOS 10 runtime is adding:

"<NSLayoutConstraint:0x174099eb0 UITableViewCellContentView:0x100546830.height == 0>",
"<NSLayoutConstraint:0x174099e60 UITableViewCellContentView:0x100546830.width == 375>"

Masonry was not in the past nor will ever modify non Masonry constraints so somehow you have to track down what new API(s) are necessary to stop those two constraints from being created/added.

aquaibm · 2016-09-14T12:14:50Z

@robertjpayne self.translatesAutoresizingMaskIntoConstraints = NO I have tried this ,not working, still the same alert.

"<NSLayoutConstraint:0x174099e60 UITableViewCellContentView:0x100546830.width == 375>"
This constraint is expected , right ? My device is iPhone 6s,so it's width should be 375, as specified by this:

        [self.contentView mas_makeConstraints:^(MASConstraintMaker *make) {
            make.left.mas_equalTo(0);
            make.right.mas_equalTo(0);
}];

aquaibm · 2016-09-14T12:18:44Z

Basically the code I've posted is to make sure the cell's contentView grows as the imageView size changes later, yes ,I am using UITableView dynamic height trick, it works well before iOS 10.

robertjpayne · 2016-09-14T12:30:55Z

@aquaibm right so this isn't an issue with Masonry it's something to do with iOS 10, unfortunately I'm not sure what exactly is causing those two extra constraints but I would poke around with some of the API's related to auto sizing and see if that is the cause.

anthonygeranio · 2016-09-15T19:41:42Z

Did you figure out what the issue was @aquaibm I seem to be discovering the same thing.

For context, @robertjpayne.. it seems that we now have to set a "placeholder" height with UITableViewCell's that require some sort of dynamic layout based off content. UITableViewAutomaticCellDimension doesn't seem to work properly.

Happy to sync and set up an example project if this helps you debug, @robertjpayne?

aquaibm · 2016-09-16T14:21:11Z

@anthonygeranio nope.

kevinh · 2016-09-18T08:17:16Z

I have the same problem “It worked well before I updated to iOS 10 and Xcode 8.” 

- (instancetype)initWithStyle:(UITableViewCellStyle)style reuseIdentifier:(NSString *)reuseIdentifier{
    self = [super initWithStyle:style reuseIdentifier:reuseIdentifier];
    if (self) {
        self.translatesAutoresizingMaskIntoConstraints = NO; // update xcode8 new add
        self.selectionStyle = UITableViewCellSelectionStyleNone;
        [self initSubview];
    }
    return self;
}


- (void)initSubview{
    self.titleLabel = [[UILabel alloc] init];
    self.titleLabel.numberOfLines = 0;
    [self.contentView addSubview:self.titleLabel];
    [self.titleLabel mas_makeConstraints:^(MASConstraintMaker *make) {
        make.top.equalTo(self.contentView).offset(25);
        make.left.equalTo(self.contentView).offset(10);
        make.right.equalTo(self.contentView).offset(-10);
    }];

    [self.contentView mas_updateConstraints:^(MASConstraintMaker *make) {
        make.top.left.equalTo(self);
        make.bottom.equalTo(self.titleLabel).offset(25);
        make.width.equalTo(@(SCREEN_WIDTH));
    }];
}

- (void)setTitle:(NSString *)title{
    _title = title;
    self.titleLabel.text = title;
}

tableview layout before is OK but update xcode8 layout will be chaotic, (all data show in first cell, See only a part of the data)

rows height is right,but all cell overlap in first cell. why?

Can anyone help me? thanks  

kevinh · 2016-09-18T12:47:49Z

@aquaibm @robertjpayne @anthonygeranio Do you have any Suggestions?

Panajev · 2016-09-18T17:22:12Z

iOS 10 is not setting the initial view constraints so if you are not super thorough, not saying you have not been :), you could easily miss some.

Sent from my iPhone

On 18 Sep 2016, at 17:50, aquaibm notifications@github.com wrote:

iOS 10's autolayout engine must have been modified, it has broken Masonry.
For example, check out the code below:
` NSLog(@"0 %@",self.contentView.constraints);
UIImageView *imageView = [UIImageView new];
imageView.contentMode = UIViewContentModeScaleAspectFill;
[self.contentView addSubview: imageView];
[imageView mas_makeConstraints:^(MASConstraintMaker *make) {
    make.left.mas_equalTo(0);
    make.right.mas_equalTo(0);
    make.top.mas_equalTo(15);
    make.height.mas_equalTo(imageView.mas_width).with.multipliedBy(9/16.0);
}];
self.pImageView = imageView;

NSLog(@"1 %@",self.contentView.constraints);`
And then got this in console:

0 (
)
1 (
"<MASLayoutConstraint:0x1702a6660 UIImageView:0x100500780.left == UITableViewCellContentView:0x100550760.left>",
"<MASLayoutConstraint:0x1702a6720 UIImageView:0x100500780.right == UITableViewCellContentView:0x100550760.right>",
"<MASLayoutConstraint:0x1702a6840 UIImageView:0x100500780.top == UITableViewCellContentView:0x100550760.top + 15>"
)

The height constraint is missing!

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

robertjpayne · 2016-09-18T22:23:49Z

@aquaibm width/height constraints are installed on the view itself if it is constrained to itself or a constant. So make sure you check imageView for that missing constraint. It will be there.

aquaibm · 2016-09-19T01:17:34Z

@Panajev @robertjpayne Oh,seems like I've made a mistake,thanks.

kevinh · 2016-09-20T01:10:11Z

I have already solved！
replace
self.translatesAutoresizingMaskIntoConstraints = NO;
to
[self.contentView mas_makeConstraints:^(MASConstraintMaker *make) { make.edges.equalTo(self); }];

I also don't know why? do you think this is helpful to you? @aquaibm

aquaibm · 2016-09-20T02:42:31Z

@kevinh Nope, your solution is not suitable for my case, which needs dynamic cell heights. Besides, are you sure there were no alerts showing in your xcode console when runing the project on your devices after replacement?

kevinh · 2016-09-20T13:01:45Z

@aquaibm yes is dynamic cell heights

old code is

- (CGFloat)cacheTableView:(UITableView *)tableView heightForRowAtIndexPath:(NSIndexPath *)indexPath indexKey:indexKey{
    CGFloat height;
    UITableViewCell *cell = [self tableView:tableView cellForRowAtIndexPath:indexPath];
    [cell setNeedsLayout];
    [cell layoutIfNeeded];
    cell.bounds = CGRectMake(0,0,self.tableView.bounds.size.width, cell.bounds.size.height);
    height = [cell.contentView systemLayoutSizeFittingSize:UILayoutFittingCompressedSize].height;
    height +=1.0f;

    [self.heightCacheDic setValue:[NSNumber numberWithFloat:height] forKey:indexKey];
    return height;
}

updated xcode8 alert

(
    "<MASLayoutConstraint:0x175ebfc80 UITableViewCellContentView:0x10c251f60.width == 414>",
    "<NSLayoutConstraint:0x171885550 UITableViewCellContentView:0x10c251f60.width <= 320>"
)

Will attempt to recover by breaking constraint 
<NSLayoutConstraint:0x171885550 UITableViewCellContentView:0x10c251f60.width <= 320>

but layout is ok

after I remove

[cell layoutIfNeeded];

the warning disappear

cclion · 2016-09-21T01:58:30Z

The solution:

UIImageView *imageView = [UIImageView new];
imageView.contentMode = UIViewContentModeScaleAspectFill;
[self.contentView addSubview: imageView];
self.contentView.translatesAutoresizingMaskIntoConstraints = NO;
[imageView mas_makeConstraints:^(MASConstraintMaker *make) {
make.left.mas_equalTo(0);
make.right.mas_equalTo(0);
make.top.mas_equalTo(15);
make.height.mas_equalTo(imageView.mas_width).with.multipliedBy(9/16.0);
make.bottom.equalTo(self.contentView);
}];
self.pImageView = imageView;

anthonygeranio · 2016-09-22T15:13:54Z

Found a solution to this. Thinking about writing a blog post about it. Any interest?

beloso · 2016-09-22T15:53:04Z

@anthonygeranio I would be interested in reading it.

anthonygeranio · 2016-09-22T19:43:48Z

Sweet gonna put something together tomorrow @beloso

Panajev · 2016-09-22T20:03:57Z

Thanks for this :)!

Sent from my iPhone

On 22 Sep 2016, at 20:43, Anthony Geranio notifications@github.com wrote:

Sweet gonna put something together tomorrow @beloso

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

beloso · 2016-09-22T20:17:18Z

@anthonygeranio I will be updating an app to iOS 10. I am using masonry and it would be good to know the problems and how to solve them before hand :)

will we need a pull request to "fix" masonry?

aquaibm · 2016-09-23T16:06:13Z

@anthonygeranio Looking forward for your solution. 💃

@cclion I will try it later, thanks.

virtualrapha · 2016-09-24T18:52:03Z

I've had a cell with fixed height and still experienced this problem. The solution that worked for my case was to override intrinsicContentSize in the cell subclass and return the size you want like so:

- (CGSize)intrinsicContentSize {
    CGFloat someFixedHeight = 250.0f;
    return CGSizeMake(CGRectGetWidth(self.bounds), someFixedHeight);
}

xiao-xi · 2016-09-28T09:30:20Z

it is good@kevinh

seventhfish · 2016-10-07T09:44:01Z

@anthonygeranio Please help, how to fix this issue

wells1013 · 2016-10-08T06:11:27Z

+1, how to fix it

zb737472783 · 2016-10-10T09:48:54Z

+1

jeffleeismyhero · 2016-10-18T00:09:15Z

I ran across this same issue. It seems that:

make.center.equalTo(myLabel.mas_centerX);

would work prior to iOS 10. After iOS 10, that does not work and I needed:

make.centerX.equalTo(myLabel.mas_centerX);

aquaibm · 2016-10-24T10:26:23Z

Finally found out the solution for my case, seems like it's not Masonry's fault to blame for this problem.

My solution is: Just don't do this

        [self.contentView mas_makeConstraints:^(MASConstraintMaker *make) {
            make.left.mas_equalTo(0);
            make.right.mas_equalTo(0);
            make.top.mas_equalTo(0);
            make.bottom.mas_equalTo(imageView.mas_bottom).with.offset(15);
        }];

Do NOT call mas_makeConstraints on tableViewCell's contentView, instead be sure that there is a constraint attached to all four sides of the contentView. Like this:

[imageView mas_makeConstraints:^(MASConstraintMaker *make) {
            make.left.mas_equalTo(self.contentView.mas_left);
            make.right.mas_equalTo(self.contentView.mas_right);
            make.top.mas_equalTo(self.contentView.mas_top);
            make.height.mas_equalTo(imageView.mas_width).with.multipliedBy(9/16.0);
            make.bottom.mas_equalTo(self.contentView.mas_bottom);
        }];

Hope this will help.

wells1013 mentioned this issue Oct 8, 2016

ios10正式版不能计算出正确高度 forkingdog/UITableView-FDTemplateLayoutCell#242

Closed

aquaibm closed this as completed Oct 24, 2016

robertjpayne mentioned this issue Jan 19, 2017

SnapKit taking automatic constaints which I did not given SnapKit/SnapKit#385

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Masonry is malfunctioning in iOS 10 while compiling with XCode 8. #382

Masonry is malfunctioning in iOS 10 while compiling with XCode 8. #382

aquaibm commented Sep 14, 2016 •

edited

Loading

robertjpayne commented Sep 14, 2016

aquaibm commented Sep 14, 2016 •

edited

Loading

robertjpayne commented Sep 14, 2016

robertjpayne commented Sep 14, 2016

aquaibm commented Sep 14, 2016 •

edited

Loading

aquaibm commented Sep 14, 2016 •

edited

Loading

robertjpayne commented Sep 14, 2016

anthonygeranio commented Sep 15, 2016

aquaibm commented Sep 16, 2016

kevinh commented Sep 18, 2016 •

edited

Loading

kevinh commented Sep 18, 2016

Panajev commented Sep 18, 2016

robertjpayne commented Sep 18, 2016 •

edited

Loading

aquaibm commented Sep 19, 2016 •

edited

Loading

kevinh commented Sep 20, 2016

aquaibm commented Sep 20, 2016 •

edited

Loading

kevinh commented Sep 20, 2016

cclion commented Sep 21, 2016

anthonygeranio commented Sep 22, 2016

beloso commented Sep 22, 2016

anthonygeranio commented Sep 22, 2016

Panajev commented Sep 22, 2016

beloso commented Sep 22, 2016

aquaibm commented Sep 23, 2016 •

edited

Loading

virtualrapha commented Sep 24, 2016

xiao-xi commented Sep 28, 2016

seventhfish commented Oct 7, 2016

wells1013 commented Oct 8, 2016

zb737472783 commented Oct 10, 2016

jeffleeismyhero commented Oct 18, 2016

aquaibm commented Oct 24, 2016 •

edited

Loading

Masonry is malfunctioning in iOS 10 while compiling with XCode 8. #382

Masonry is malfunctioning in iOS 10 while compiling with XCode 8. #382

Comments

aquaibm commented Sep 14, 2016 • edited Loading

robertjpayne commented Sep 14, 2016

aquaibm commented Sep 14, 2016 • edited Loading

robertjpayne commented Sep 14, 2016

robertjpayne commented Sep 14, 2016

aquaibm commented Sep 14, 2016 • edited Loading

aquaibm commented Sep 14, 2016 • edited Loading

robertjpayne commented Sep 14, 2016

anthonygeranio commented Sep 15, 2016

aquaibm commented Sep 16, 2016

kevinh commented Sep 18, 2016 • edited Loading

kevinh commented Sep 18, 2016

Panajev commented Sep 18, 2016

robertjpayne commented Sep 18, 2016 • edited Loading

aquaibm commented Sep 19, 2016 • edited Loading

kevinh commented Sep 20, 2016

aquaibm commented Sep 20, 2016 • edited Loading

kevinh commented Sep 20, 2016

cclion commented Sep 21, 2016

anthonygeranio commented Sep 22, 2016

beloso commented Sep 22, 2016

anthonygeranio commented Sep 22, 2016

Panajev commented Sep 22, 2016

beloso commented Sep 22, 2016

aquaibm commented Sep 23, 2016 • edited Loading

virtualrapha commented Sep 24, 2016

xiao-xi commented Sep 28, 2016

seventhfish commented Oct 7, 2016

wells1013 commented Oct 8, 2016

zb737472783 commented Oct 10, 2016

jeffleeismyhero commented Oct 18, 2016

aquaibm commented Oct 24, 2016 • edited Loading

aquaibm commented Sep 14, 2016 •

edited

Loading

aquaibm commented Sep 14, 2016 •

edited

Loading

aquaibm commented Sep 14, 2016 •

edited

Loading

aquaibm commented Sep 14, 2016 •

edited

Loading

kevinh commented Sep 18, 2016 •

edited

Loading

robertjpayne commented Sep 18, 2016 •

edited

Loading

aquaibm commented Sep 19, 2016 •

edited

Loading

aquaibm commented Sep 20, 2016 •

edited

Loading

aquaibm commented Sep 23, 2016 •

edited

Loading

aquaibm commented Oct 24, 2016 •

edited

Loading