Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DYPlayer::getDevice should have parameter #2

Closed
SnijderC opened this issue Jan 28, 2020 · 1 comment
Closed

DYPlayer::getDevice should have parameter #2

SnijderC opened this issue Jan 28, 2020 · 1 comment
Assignees
@SnijderC
Labels
bug Something isn't working

Comments

@SnijderC
Copy link
Owner

I guess I interpreted the manual incorrectly, this was already not doing exactly what I expected but in hindsight that makes sense.

It should be refactored to check if a storage device is "online", probably return a boolean, in the spirit of DYPlayer::checkDeviceOnline(). The latter should probably be the name of the former.
@SnijderC SnijderC added the bug Something isn't working label Jan 28, 2020
@SnijderC SnijderC self-assigned this Jan 28, 2020
@SnijderC SnijderC mentioned this issue Jan 28, 2020
Closed
@SnijderC
Copy link
Owner Author

No, I was wrong it is implemented okay, maybe the name should be changed, but it's not clear to me what this command does and what aa 0a does..

@hicksan hicksan mentioned this issue Sep 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SnijderC SnijderC

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SnijderC