Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reading file formats with no default schema #1936

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

sfc-gh-ngaberel
Copy link
Contributor

Updates the ShowById sdk method to specify the schema (IN SCHEMA "db"."schema") in which to search for a file format.

Test Plan

  • New integration test covering broken case

References

@sfc-gh-ngaberel sfc-gh-ngaberel marked this pull request as ready for review July 7, 2023 22:34
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Integration tests failure for 04d7538abe96b0573bc9eda15d36d3bbd1cf82d8

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Integration tests success for 002d5347b4a9c55b83039f2ccf157a6e18f3cba7

@sfc-gh-ngaberel sfc-gh-ngaberel force-pushed the snow-858433-file-format-showbyid branch from 002d534 to 93a686a Compare July 7, 2023 22:58
@sfc-gh-ngaberel sfc-gh-ngaberel enabled auto-merge (squash) July 7, 2023 22:59
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Integration tests success for 93a686abbb1c4511ee8d59bfc1a5268ebe1f56ab

@sfc-gh-ngaberel sfc-gh-ngaberel merged commit c5602f5 into main Jul 7, 2023
9 checks passed
@sfc-gh-ngaberel sfc-gh-ngaberel deleted the snow-858433-file-format-showbyid branch July 7, 2023 23:16
@rjminchuk
Copy link

Thank you! Will give it a shot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to terraform plan snowflake_file_format on 0.68.0
3 participants