chore: Makefile cleanup #1995
chore: Makefile cleanup #1995
Conversation
|
Integration tests success for 37fb79ad1b5c280ebce49c4d148fe7f719b0b1da |
|
Integration tests success for 0db1aa0bcba7d9da427db64d5765ea3a06ce3c5a |
|
Integration tests success for 7273ce42aab16706343a484420eb610060de22fd |
|
Integration tests success for 2aa31f6aa3f3a9d422b98b936438aba77686d238 |
Makefile
Outdated
| CGO_ENABLED=1 $(go_test) -race -coverprofile=coverage.txt -covermode=atomic $(TESTARGS) ./pkg/snowflake/... | ||
|
|
||
| test: ## run the tests (except sdk tests) | ||
| CGO_ENABLED=1 go test -race $(COVERAGE_FLAGS) ./pkg/resources/... |
There was a problem hiding this comment.
Are we not running data source tests?
There was a problem hiding this comment.
these are only unit tests which are now run by Unit tests giuthub action (defined in file unit.yml). TBH I would like to remove it also, and remove it from unit.yml, but I was not sure if someone is using it independently (I wrote my concerns in the doc that I have shared internally).
There was a problem hiding this comment.
I can remove it also, why not :)
There was a problem hiding this comment.
The name "unit test" is confusing, because its not including any unit tests from SDK. There may be some minimal "unit tests" that test specific helper functions / validation functions for the provider,
perhaps we should create two different workflows to test the SDK and the Terraform Provider. That would make it easier to split later. And then these makefile commands could be more specific such as make unit-test provider or something to that effect.
sfc-gh-asawicki
force-pushed
the
makefile-cleanup
branch
from
2aa31f6
to
1aadca1
Compare
Makefile
Outdated
| CGO_ENABLED=1 $(go_test) -race -coverprofile=coverage.txt -covermode=atomic $(TESTARGS) ./pkg/snowflake/... | ||
|
|
||
| test: ## run the tests (except sdk tests) | ||
| CGO_ENABLED=1 go test -race $(COVERAGE_FLAGS) ./pkg/resources/... |
There was a problem hiding this comment.
The name "unit test" is confusing, because its not including any unit tests from SDK. There may be some minimal "unit tests" that test specific helper functions / validation functions for the provider,
perhaps we should create two different workflows to test the SDK and the Terraform Provider. That would make it easier to split later. And then these makefile commands could be more specific such as make unit-test provider or something to that effect.
|
Integration tests failure for 1aadca12d81a5e4ee202dbb962c0cdfaf56d4723 |
|
Integration tests success for 5ec612e83ca08fa38301a5336c270b1e2b6a46ba |
|
Integration tests success for d8a718f15cc3fe9a247bc9ee466c9f5960db1224 |
sfc-gh-asawicki
force-pushed
the
makefile-cleanup
branch
from
d8a718f
to
835d683
Compare
|
Integration tests failure for 835d683fd22dac0ed1481e2764278fa70e92b466 |
|
Integration tests success for 835d683fd22dac0ed1481e2764278fa70e92b466 |
sfc-gh-asawicki
force-pushed
the
makefile-cleanup
branch
from
835d683
to
96fd3c3
Compare
|
Integration tests failure for 96fd3c33caeebbfbfd95dc03eb5150cc100f84de |
|
Integration tests success for 96fd3c33caeebbfbfd95dc03eb5150cc100f84de |
Changes
Overall Makefile cleanup:
There are still some open discussions, so more changes will be added here or to follow-up PRs.
Test Plan