Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add missing database role operations to SDK #2014

Merged
merged 10 commits into from
Aug 17, 2023
Merged

feat: Add missing database role operations to SDK #2014

merged 10 commits into from
Aug 17, 2023

Conversation

sfc-gh-asawicki
Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki commented Aug 16, 2023 •
edited

Changes

Test Plan

  • unit tests (sql generation and validations)
  • integration tests (sql invocation)
  • acceptance tests (nothing should break)

References

@github-actions
Copy link

Integration tests success for 8c66b0c1602beff8a34152c23df023add95d65f4

@sfc-gh-asawicki sfc-gh-asawicki marked this pull request as ready for review August 16, 2023 13:40
@sfc-gh-asawicki sfc-gh-asawicki merged commit d2ea67d into main Aug 17, 2023
12 checks passed
@sfc-gh-asawicki sfc-gh-asawicki deleted the add-missing-database-role-operations-to-sdk branch August 17, 2023 11:21
@snowflake-release-please snowflake-release-please bot mentioned this pull request Aug 16, 2023
Merged
@abid1995 abid1995 mentioned this pull request Aug 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-pbosak sfc-gh-pbosak sfc-gh-pbosak approved these changes

@sfc-gh-swinkler sfc-gh-swinkler Awaiting requested review from sfc-gh-swinkler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sfc-gh-asawicki @sfc-gh-pbosak