New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Rename and reuse validatableOpts interface #2016

Merged

sfc-gh-asawicki merged 2 commits into main from rename-and-reuse-validateable-opts-interface

Aug 17, 2023

Collaborator

sfc-gh-asawicki commented Aug 17, 2023 •

edited

Description

Reuse validatableOpts interface:

rename it to validatable
rename method to validate()
add implementation guards for all XxxOptions structs

Test Plan

acceptance tests (should not break)

sfc-gh-asawicki requested review from sfc-gh-swinkler and sfc-gh-pbosak

August 17, 2023 11:20

github-actions bot commented Aug 17, 2023

Integration tests success for ecc7ff168c944ad65ad70f6db23a7851dcfe5abe

sfc-gh-asawicki added 2 commits

August 17, 2023 13:39


          Rename validatableOpts interface and its method

e3afc9d


          Add validatable implementation guards

06315f0

sfc-gh-asawicki force-pushed the rename-and-reuse-validateable-opts-interface branch from ecc7ff1 to 06315f0 Compare

August 17, 2023 11:40

sfc-gh-asawicki marked this pull request as ready for review

August 17, 2023 11:40

github-actions bot commented Aug 17, 2023

Integration tests success for 06315f0b899dfd57357436c776d78363ed2ab416

sfc-gh-pbosak approved these changes

View reviewed changes

sfc-gh-asawicki merged commit 4b42848 into main

10 checks passed

sfc-gh-asawicki deleted the rename-and-reuse-validateable-opts-interface branch

August 17, 2023 14:11

snowflake-release-please bot mentioned this pull request

chore(main): release 0.70.0 #1991

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment