Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add grant privileges to database role to SDK #2023

Merged
merged 19 commits into from
Sep 21, 2023
Merged

feat: Add grant privileges to database role to SDK #2023

merged 19 commits into from
Sep 21, 2023

Conversation

sfc-gh-asawicki
Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki commented Aug 21, 2023 •
edited

Changes

  • Implement granting privileges to database roles in SDK:
    • Add implementation based on references
    • split existing grants implementation into files
    • fix returned Grant type
    • add missing validations
    • correct existing validations
  • What was NOT changed:
    • Grants interface is not using our new Requests, new methods are also not using them, to make them consistent inside this interface and not to do too much refactoring in this PR

Test Plan

  • unit tests (sql generation and validations)
  • integration tests (sql invocation)
  • acceptance tests (nothing should break yet)

References

Base automatically changed from use-database-role-from-sdk to main August 21, 2023 16:57
@github-actions
Copy link

Integration tests failure for bc7247a17345abbcf45afb2480469109feb162df

@sfc-gh-asawicki sfc-gh-asawicki force-pushed the add-grant-privileges-to-database-role-to-sdk branch from bc7247a to 7ff784a Compare August 21, 2023 17:03
@github-actions
Copy link

Integration tests failure for 7ff784a3b7f9c7e631c437ce6ab73686f193a993

1 similar comment
@github-actions
Copy link

Integration tests failure for 7ff784a3b7f9c7e631c437ce6ab73686f193a993

@github-actions
Copy link

Integration tests failure for ee88684a6e466503b119ee2c44a1d40353025113

@github-actions
Copy link

Integration tests success for c572560821f9a63f90b62937542acea15649c513

@sfc-gh-asawicki sfc-gh-asawicki force-pushed the add-grant-privileges-to-database-role-to-sdk branch from c572560 to 87a99a6 Compare August 21, 2023 22:45
@github-actions
Copy link

Integration tests success for 87a99a6077f60759d8702ba7add85128ac8943d8

@sfc-gh-asawicki sfc-gh-asawicki force-pushed the add-grant-privileges-to-database-role-to-sdk branch from 87a99a6 to 8d1f02f Compare August 21, 2023 23:25
@github-actions
Copy link

Integration tests failure for 8d1f02f18ea5dafe00063376120e9e1aacf8bbcc

@sfc-gh-asawicki sfc-gh-asawicki force-pushed the add-grant-privileges-to-database-role-to-sdk branch from 8d1f02f to f1f242c Compare August 22, 2023 07:26
@github-actions
Copy link

Integration tests failure for f1f242c676dce9750f105e1abac3269849e9e7a0

1 similar comment
@github-actions
Copy link

Integration tests failure for f1f242c676dce9750f105e1abac3269849e9e7a0

@sfc-gh-asawicki sfc-gh-asawicki force-pushed the add-grant-privileges-to-database-role-to-sdk branch from f1f242c to 1e282a7 Compare August 22, 2023 11:25
@github-actions
Copy link

Integration tests success for 1e282a76e324f7572ca049bf86cd1f15ea5a6eb7

@sfc-gh-asawicki sfc-gh-asawicki marked this pull request as ready for review August 22, 2023 11:45
sfc-gh-pbosak
sfc-gh-pbosak reviewed Aug 23, 2023
View reviewed changes
pkg/sdk/grants.go Outdated Show resolved Hide resolved
pkg/sdk/grants.go Outdated Show resolved Hide resolved
pkg/sdk/grants_integration_test.go Show resolved Hide resolved
pkg/sdk/grants_integration_test.go Show resolved Hide resolved
pkg/sdk/grants_validations.go Outdated Show resolved Hide resolved
@github-actions
Copy link

Integration tests failure for 39fd8b06147042c46567d31105e3a6c2aa374303

3 similar comments
@github-actions
Copy link

Integration tests failure for 39fd8b06147042c46567d31105e3a6c2aa374303

@github-actions
Copy link

Integration tests failure for 39fd8b06147042c46567d31105e3a6c2aa374303

@github-actions
Copy link

Integration tests failure for 39fd8b06147042c46567d31105e3a6c2aa374303

@sfc-gh-asawicki sfc-gh-asawicki force-pushed the add-grant-privileges-to-database-role-to-sdk branch from 39fd8b0 to 69a69f8 Compare September 21, 2023 12:22
@github-actions
Copy link

Integration tests failure for 69a69f8c6340e4d683999631d991f35e376c1f2d

@github-actions
Copy link

Integration tests success for 69a69f8c6340e4d683999631d991f35e376c1f2d

@sfc-gh-asawicki sfc-gh-asawicki merged commit 717289f into main Sep 21, 2023
8 checks passed
@sfc-gh-asawicki sfc-gh-asawicki deleted the add-grant-privileges-to-database-role-to-sdk branch September 21, 2023 14:57
@snowflake-release-please snowflake-release-please bot mentioned this pull request Sep 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@sfc-gh-pbosak sfc-gh-pbosak sfc-gh-pbosak approved these changes

@sfc-gh-swinkler sfc-gh-swinkler Awaiting requested review from sfc-gh-swinkler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sfc-gh-asawicki @sfc-gh-pbosak