Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add dynamic tables to grants #2059

Merged
merged 8 commits into from
Sep 20, 2023
Merged

fix: add dynamic tables to grants #2059

merged 8 commits into from
Sep 20, 2023

Conversation

sfc-gh-swinkler
Copy link
Collaborator

@sfc-gh-swinkler sfc-gh-swinkler commented Sep 17, 2023 •
edited

@github-actions
Copy link

Integration tests failure for 98a31f9016c085f68296a49d6d78519f133d14f3

@github-actions
Copy link

Integration tests failure for 0fd77641664b30ad4020986becba557f4541b1a7

github-actions[bot]
github-actions bot reviewed Sep 19, 2023
View reviewed changes
pkg/sdk/password_policy_integration_test.go Outdated
@@ -104,7 +104,7 @@ func TestInt_PasswordPolicyCreate(t *testing.T) {
PasswordMaxAgeDays: Int(30),
PasswordMaxRetries: Int(5),
PasswordLockoutTimeMins: Int(30),
Comment: String("test comment"),
//Comment: String("test comment"),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
File is not gofumpt-ed (gofumpt)

pkg/sdk/password_policy_integration_test.go Outdated
@@ -131,7 +131,7 @@ func TestInt_PasswordPolicyCreate(t *testing.T) {
PasswordMinLength: Int(10),
PasswordMaxLength: Int(20),
PasswordMinUpperCaseChars: Int(5),
Comment: String("test comment"),
//Comment: String("test comment"),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
File is not gofumpt-ed (gofumpt)

@github-actions
Copy link

Integration tests failure for 230e5e537c93615a13497d567610ed9838d689b9

@github-actions
Copy link

Integration tests failure for b9b357ecf185bcb1cbad62e8e54dfab835f708fa

2 similar comments
@github-actions
Copy link

Integration tests failure for b9b357ecf185bcb1cbad62e8e54dfab835f708fa

@github-actions
Copy link

Integration tests failure for b9b357ecf185bcb1cbad62e8e54dfab835f708fa

@github-actions
Copy link

Integration tests failure for 599b7f760dc84a4e07d098193d0a43733fbd1bb3

@github-actions
Copy link

Integration tests failure for 6d212d39a3c20dc67a10d827f9747084a8065a98

@github-actions
Copy link

Integration tests success for d56fa863c3d6d0898d7c03c4f986e2f0e38993b5

@sfc-gh-asawicki sfc-gh-asawicki merged commit 3767de9 into main Sep 20, 2023
8 checks passed
@sfc-gh-asawicki sfc-gh-asawicki deleted the dynamic-table-grants branch September 20, 2023 12:32
@snowflake-release-please snowflake-release-please bot mentioned this pull request Sep 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@sfc-gh-jcieslak sfc-gh-jcieslak sfc-gh-jcieslak approved these changes

@sfc-gh-asawicki sfc-gh-asawicki sfc-gh-asawicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sfc-gh-swinkler @sfc-gh-jcieslak @sfc-gh-asawicki