feat: add application to sdk #2350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests failure for 63b24839b1dd20a94a87d91ade2062dfdd3c214b |
sfc-gh-asawicki
requested changes
Jan 17, 2024
| } | ||
| err := client.Applications.Alter(ctx, sdk.NewAlterApplicationRequest(id).WithSetTags(setTags)) | ||
| require.NoError(t, err) | ||
| assertApplication(t, id, applicationPackageName, version, patch) |
There was a problem hiding this comment.
assertApplication doesn't check tags, so this test is not proving that SetTags and UnsetTags work
There was a problem hiding this comment.
tags don't currently work for applications, so added a note
There was a problem hiding this comment.
So maybe we should skip it for now? It doesn't make sense if there're no asserts to check tags (+ knowing they're not supported yet)
|
Integration tests failure for 799e89fb812f8265377a0b0b140b890688a29a0a |
sfc-gh-asawicki
requested changes
Jan 22, 2024
|
Integration tests failure for b75eaeceb71345afaa10beacd90ca22d6729dc2d |
|
Integration tests failure for 9ce6907abd2eb6528efaa93b4cca74b799ff1a90 |
|
Integration tests failure for d0e33d735a0df480c48f107cfac4458b56859586 |
1 similar comment
|
Integration tests failure for d0e33d735a0df480c48f107cfac4458b56859586 |
sfc-gh-asawicki
previously approved these changes
Jan 23, 2024
sfc-gh-jcieslak
previously approved these changes
Jan 23, 2024
sfc-gh-swinkler
dismissed stale reviews from sfc-gh-jcieslak and sfc-gh-asawicki
via
1060c36
|
Integration tests failure for 1060c36b85e8ea60ac7a00f2c7f4f170dd6df78f |
|
Integration tests failure for 72bcabb65e677458345a4444beacf7404ae1bc24 |
|
Integration tests failure for 5db91973aeab8d7a95df46c08cf1d3359d41c551 |
sfc-gh-jcieslak
pushed a commit
that referenced
this pull request
Feb 2, 2024
🤖 I have created a release *beep* *boop* --- ## [0.85.0](v0.84.1...v0.85.0) (2024-02-01) ### 🎉 **What's new:** * Add API integration to the SDK ([#2409](#2409)) ([23acda5](23acda5)) * add application to sdk ([#2350](#2350)) ([de97ad8](de97ad8)) * add external funcs to sdk ([#2440](#2440)) ([c8cf09b](c8cf09b)) * Add grant privileges to share resource ([#2447](#2447)) ([d8241a5](d8241a5)) * Add materialized view to the SDK ([#2403](#2403)) ([a5ce699](a5ce699)) * Add notification integration to the SDK ([#2412](#2412)) ([d84240c](d84240c)) * add sequences to sdk ([#2351](#2351)) ([d2e5ffd](d2e5ffd)) * add snowflake grant privileges to account role ([#2365](#2365)) ([e3d086e](e3d086e)) * add streamlits to sdk ([#2400](#2400)) ([129d24c](129d24c)) * add-call-with to sdk ([#2337](#2337)) ([ebcd1bc](ebcd1bc)) * stages migration follow-up ([#2372](#2372)) ([3939dbe](3939dbe)) * Use API integration from SDK ([#2429](#2429)) ([1ccc864](1ccc864)) * Use managed account from the SDK ([#2420](#2420)) ([3aaa080](3aaa080)) * Use materialized views and views from SDK ([#2448](#2448)) ([dc66d02](dc66d02)) * Use notification integration from sdk ([#2445](#2445)) ([e8915cc](e8915cc)) * use roles from the SDK ([#2405](#2405)) ([c645b4d](c645b4d)) * Use row access policy from SDK ([#2428](#2428)) ([119af5e](119af5e)) * Use SDK in the storage integration ([#2380](#2380)) ([ce0741c](ce0741c)) * use sequence from sdk and add ordering attr ([#2419](#2419)) ([973b8f7](973b8f7)), closes [#2387](#2387) * Use stage from sdk ([#2427](#2427)) ([c17effd](c17effd)) ### 🔧 **Misc** * add missing deprecation message ([#2451](#2451)) ([77de569](77de569)) ### 🐛 **Bug fixes:** * account role test ([#2422](#2422)) ([c1b47d1](c1b47d1)) * Adjust tests after Snowflake behavior change ([#2404](#2404)) ([8c03ffb](8c03ffb)) * app-pkg unset ([#2399](#2399)) ([fedb1df](fedb1df)) * Fix some bugs ([#2421](#2421)) ([dec7cd9](dec7cd9)), closes [#2358](#2358) [#2369](#2369) [#2329](#2329) * snowflake_grant_privileges_to_role read ([#2424](#2424)) ([5385cec](5385cec)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds snowflake application to sdk
https://docs.snowflake.com/en/sql-reference/sql/create-application