Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stages migration follow-up #2372

Merged
merged 4 commits into from Jan 23, 2024
Merged

Conversation

sfc-gh-jcieslak
Copy link
Collaborator

@sfc-gh-jcieslak sfc-gh-jcieslak commented Jan 18, 2024

Follow-up for #2163

  • Added missing tests for external resources (only s3compat was left, but created a separate ticket for later)
  • Fixed set comment on the file format + tests for it
  • File functions like GET, LS, COPY INTO, etc. are left for later
  • Cleanup helper functions for creating stages

@sfc-gh-jcieslak sfc-gh-jcieslak marked this pull request as ready for review January 18, 2024 15:21
Copy link

Integration tests failure for 644f621370ddeac91a6b54c462d3420c2f2dd226

Copy link

Integration tests failure for d9a08e82fc86a52b1e203635e6f8c2290f108436

Copy link

Integration tests failure for d0f09ab938f48f55f0134667daa9bbfa5cbee04a

pkg/sdk/testint/helpers_test.go Outdated Show resolved Hide resolved
Copy link

Integration tests failure for 2b522e4ee3cfc9405e2cfc9dcef4ad3f9333a919

Copy link

Integration tests failure for 7ca2f921d2053fc50e59b8c2289fd0a97d0ba3c6

1 similar comment
Copy link

Integration tests failure for 7ca2f921d2053fc50e59b8c2289fd0a97d0ba3c6

@sfc-gh-jcieslak sfc-gh-jcieslak merged commit 3939dbe into main Jan 23, 2024
2 of 7 checks passed
@sfc-gh-jcieslak sfc-gh-jcieslak deleted the stage-migration-follow-up branch January 23, 2024 10:13
Copy link

Integration tests cancelled for e385826e063a6bd0a0cf2032f6f4cf42d51c7ebc

sfc-gh-jcieslak pushed a commit that referenced this pull request Feb 2, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.85.0](v0.84.1...v0.85.0)
(2024-02-01)


### 🎉 **What's new:**

* Add API integration to the SDK
([#2409](#2409))
([23acda5](23acda5))
* add application to sdk
([#2350](#2350))
([de97ad8](de97ad8))
* add external funcs to sdk
([#2440](#2440))
([c8cf09b](c8cf09b))
* Add grant privileges to share resource
([#2447](#2447))
([d8241a5](d8241a5))
* Add materialized view to the SDK
([#2403](#2403))
([a5ce699](a5ce699))
* Add notification integration to the SDK
([#2412](#2412))
([d84240c](d84240c))
* add sequences to sdk
([#2351](#2351))
([d2e5ffd](d2e5ffd))
* add snowflake grant privileges to account role
([#2365](#2365))
([e3d086e](e3d086e))
* add streamlits to sdk
([#2400](#2400))
([129d24c](129d24c))
* add-call-with to sdk
([#2337](#2337))
([ebcd1bc](ebcd1bc))
* stages migration follow-up
([#2372](#2372))
([3939dbe](3939dbe))
* Use API integration from SDK
([#2429](#2429))
([1ccc864](1ccc864))
* Use managed account from the SDK
([#2420](#2420))
([3aaa080](3aaa080))
* Use materialized views and views from SDK
([#2448](#2448))
([dc66d02](dc66d02))
* Use notification integration from sdk
([#2445](#2445))
([e8915cc](e8915cc))
* use roles from the SDK
([#2405](#2405))
([c645b4d](c645b4d))
* Use row access policy from SDK
([#2428](#2428))
([119af5e](119af5e))
* Use SDK in the storage integration
([#2380](#2380))
([ce0741c](ce0741c))
* use sequence from sdk and add ordering attr
([#2419](#2419))
([973b8f7](973b8f7)),
closes
[#2387](#2387)
* Use stage from sdk
([#2427](#2427))
([c17effd](c17effd))


### 🔧 **Misc**

* add missing deprecation message
([#2451](#2451))
([77de569](77de569))


### 🐛 **Bug fixes:**

* account role test
([#2422](#2422))
([c1b47d1](c1b47d1))
* Adjust tests after Snowflake behavior change
([#2404](#2404))
([8c03ffb](8c03ffb))
* app-pkg unset
([#2399](#2399))
([fedb1df](fedb1df))
* Fix some bugs
([#2421](#2421))
([dec7cd9](dec7cd9)),
closes
[#2358](#2358)
[#2369](#2369)
[#2329](#2329)
* snowflake_grant_privileges_to_role read
([#2424](#2424))
([5385cec](5385cec))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants