feat: Use API integration from SDK #2429
Conversation
sfc-gh-asawicki
changed the title
|
Integration tests failure for 5d4feda66ad41af812c51460adaa758f03c7813b |
| return nil | ||
| } | ||
| return fmt.Errorf("could not show api integration: %w", err) | ||
| log.Printf("[DEBUG] api integration (%s) not found", d.Id()) |
There was a problem hiding this comment.
one thing we should discuss is how if you don't have required permissions, then the show command will return error same as if the object didn't exist. if customer applies using accountadmin, then later with a less privileged role, then their terraform state file will be completely wiped out. should we check that user has sufficient privileges to do show command before setting resource id to empty? I think its not necessary, but it might be a good improvement later.
There was a problem hiding this comment.
That's true for all the resources, so I am adding this to SNOW-867235.
| } | ||
| return allowedPrefixes | ||
| } | ||
|
|
||
| // CreateAPIIntegration implements schema.CreateFunc. | ||
| func CreateAPIIntegration(d *schema.ResourceData, meta interface{}) error { |
There was a problem hiding this comment.
jan was using createcontext function in his stage pr, I thought that was a pretty good idea. i don't think its necessary to do in these prs now, but its something we should eventually do for all resources as part of a larger refactoring effort
There was a problem hiding this comment.
Added as a part of SNOW-867235.
|
Integration tests failure for e5e3eedd0af088642a32e70c1fe0a77cbf70424b |
1 similar comment
|
Integration tests failure for e5e3eedd0af088642a32e70c1fe0a77cbf70424b |
🤖 I have created a release *beep* *boop* --- ## [0.85.0](v0.84.1...v0.85.0) (2024-02-01) ### 🎉 **What's new:** * Add API integration to the SDK ([#2409](#2409)) ([23acda5](23acda5)) * add application to sdk ([#2350](#2350)) ([de97ad8](de97ad8)) * add external funcs to sdk ([#2440](#2440)) ([c8cf09b](c8cf09b)) * Add grant privileges to share resource ([#2447](#2447)) ([d8241a5](d8241a5)) * Add materialized view to the SDK ([#2403](#2403)) ([a5ce699](a5ce699)) * Add notification integration to the SDK ([#2412](#2412)) ([d84240c](d84240c)) * add sequences to sdk ([#2351](#2351)) ([d2e5ffd](d2e5ffd)) * add snowflake grant privileges to account role ([#2365](#2365)) ([e3d086e](e3d086e)) * add streamlits to sdk ([#2400](#2400)) ([129d24c](129d24c)) * add-call-with to sdk ([#2337](#2337)) ([ebcd1bc](ebcd1bc)) * stages migration follow-up ([#2372](#2372)) ([3939dbe](3939dbe)) * Use API integration from SDK ([#2429](#2429)) ([1ccc864](1ccc864)) * Use managed account from the SDK ([#2420](#2420)) ([3aaa080](3aaa080)) * Use materialized views and views from SDK ([#2448](#2448)) ([dc66d02](dc66d02)) * Use notification integration from sdk ([#2445](#2445)) ([e8915cc](e8915cc)) * use roles from the SDK ([#2405](#2405)) ([c645b4d](c645b4d)) * Use row access policy from SDK ([#2428](#2428)) ([119af5e](119af5e)) * Use SDK in the storage integration ([#2380](#2380)) ([ce0741c](ce0741c)) * use sequence from sdk and add ordering attr ([#2419](#2419)) ([973b8f7](973b8f7)), closes [#2387](#2387) * Use stage from sdk ([#2427](#2427)) ([c17effd](c17effd)) ### 🔧 **Misc** * add missing deprecation message ([#2451](#2451)) ([77de569](77de569)) ### 🐛 **Bug fixes:** * account role test ([#2422](#2422)) ([c1b47d1](c1b47d1)) * Adjust tests after Snowflake behavior change ([#2404](#2404)) ([8c03ffb](8c03ffb)) * app-pkg unset ([#2399](#2399)) ([fedb1df](fedb1df)) * Fix some bugs ([#2421](#2421)) ([dec7cd9](dec7cd9)), closes [#2358](#2358) [#2369](#2369) [#2329](#2329) * snowflake_grant_privileges_to_role read ([#2424](#2424)) ([5385cec](5385cec)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
SET AZURE_TENANT_IDandSET GOOGLE_AUDIENCE) to the SDK. Added tests.