fix: grants on external volumes #2538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests failure for 0fcaed649edd09c7ded4b78239c2b3c3f95ca970 |
sfc-gh-asawicki
requested changes
Feb 22, 2024
pkg/resources/grant_privileges_to_account_role_acceptance_test.go
Outdated
Show resolved
Hide resolved
|
Integration tests failure for cfbf77934292e00c832c0ddd87f5dafd2091a5b6 |
|
Integration tests failure for a81bd04c73967a2a3f036835faffb28f2c5d07e5 |
sfc-gh-asawicki
previously approved these changes
Feb 28, 2024
|
Integration tests failure for 6bea5e5e98da8d4e9258c66382105e73ee851238 |
# Conflicts: # pkg/resources/grant_privileges_to_account_role_acceptance_test.go
|
Integration tests failure for 96f509937e9cba0611944abd8c47fa9bbd4d4001 |
|
Integration tests failure for 810dcdfd5c50434cb14b524f4c926126234e0b12 |
sfc-gh-asawicki
approved these changes
Feb 28, 2024
sfc-gh-jcieslak
pushed a commit
that referenced
this pull request
Feb 28, 2024
🤖 I have created a release *beep* *boop* --- ## [0.87.0](v0.86.0...v0.87.0) (2024-02-28) ### 🎉 **What's new:** * Add network rule to the sdk ([#2526](#2526)) ([b379565](b379565)) * supports collation of table column ([#2496](#2496)) ([56771f1](56771f1)) ### 🔧 **Misc** * Clean up environment variables in tests and on CI ([#2543](#2543)) ([9a10cb1](9a10cb1)) * replace warning in new grant resources with info log ([#2521](#2521)) ([c3014b9](c3014b9)) ### 🐛 **Bug fixes:** * data retention days follow up ([#2566](#2566)) ([7aba384](7aba384)) * data retention time parameters ([#2502](#2502)) ([76abf21](76abf21)) * data retention time parameters follow-up ([#2530](#2530)) ([5544544](5544544)) * Demote warning to info and set volatility for procedures and functions ([#2567](#2567)) ([abaad7c](abaad7c)), closes [#2536](#2536) * Fix ACCOUNT PARAMETERS option failover group resource ([#2522](#2522)) ([61883f3](61883f3)), closes [#2517](#2517) * Fix failover group alter syntax and suppression for pipe statement ([#2562](#2562)) ([24d76c3](24d76c3)) * Fix few tests ([#2515](#2515)) ([a523a6b](a523a6b)) * Fix provider config hierarchy ([#2551](#2551)) ([677a12b](677a12b)) * Fix query_results in unsafe_execute resource ([#2512](#2512)) ([94ca158](94ca158)), closes [#2491](#2491) * Fix replication for database resource ([#2524](#2524)) ([767fbce](767fbce)), closes [#2021](#2021) * Fix show by id for external functions ([#2531](#2531)) ([d910a84](d910a84)), closes [#2528](#2528) * Fix various small problems ([#2552](#2552)) ([f558ce6](f558ce6)) * Granting database roles ([#2511](#2511)) ([dc27d64](dc27d64)), closes [#2402](#2402) * grants on external volumes ([#2538](#2538)) ([1de9a29](1de9a29)) * Handle old reference for table_id in table constraint resource ([#2558](#2558)) ([d1e8912](d1e8912)), closes [#2535](#2535) * loosen identifier field validation for account object identifiers ([#2564](#2564)) ([a5ed8cd](a5ed8cd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2533
Terraform couldn't read privileges for External volumes, because Snowflake returns a shorter
VOLUMEname where we expectEXTERNAL VOLUMEto be returned. The proposed fix relies on replacingEXTERNAL VOLUMEwithVOLUMEin the prepare read request function so that the Read operation will be untouched and will work for external volumes.Test Plan
Other
Wrote to the docs team to add this case to the SHOW GRANTS page.
Update: added missing privileges (CREATE MODEL needed for #2563)