chore: Chore use get or skip in other tests #2570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sfc-gh-asawicki
commented
Feb 28, 2024
sfc-gh-asawicki
commented
- use helper methods
- clean the used environment variables
- Use GetOrSkipTest - Introduce SkipTestIfNotSet - Remove old SKIP_* envs - Rename existing envs to follow the same naming convention - Update Makefile and README
|
Integration tests failure for efc3f70fefad59019a46618f44c8bb41b58a2f46 |
sfc-gh-jcieslak
approved these changes
Feb 29, 2024
sfc-gh-jcieslak
pushed a commit
that referenced
this pull request
Mar 6, 2024
🤖 I have created a release *beep* *boop* --- ## [0.87.1](v0.87.0...v0.87.1) (2024-03-06) ### 🔧 **Misc** * Add deprecated resources/datasources to the main documentation page ([#2581](#2581)) ([68bbf4f](68bbf4f)) * Add deprecation message to docs ([#2578](#2578)) ([3675d6d](3675d6d)) * Add Terraform setup to the testing pipeline ([#2579](#2579)) ([216e35a](216e35a)) * Chore use get or skip in other tests ([#2570](#2570)) ([2829b90](2829b90)) * modify provider context to pass snowflake client instead of db connection ([#2577](#2577)) ([e7fd4ef](e7fd4ef)) * Speed up tests ([#2580](#2580)) ([f003715](f003715)) ### 🐛 **Bug fixes:** * file_format validate() for field_optionally_enclosed_by ([#2575](#2575)) ([5da5d93](5da5d93)) * Fix import for account parameter ([#2594](#2594)) ([cac884c](cac884c)), closes [#2573](#2573) * support snowflake application as database ([#2596](#2596)) ([b9a4a19](b9a4a19)) * tag identifiers problems ([#2534](#2534)) ([3c300e1](3c300e1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.