Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Resource to manage a user's public keys #540

Merged
merged 14 commits into from
May 12, 2021
Merged

feat: Resource to manage a user's public keys #540

merged 14 commits into from
May 12, 2021

Conversation

edulop91
Copy link

A resource to manage a user's public keys. Note that this resource is intended to be used when users are managed through an external source (eg SCIM) and it'll conflict with the snowflake_user resource.

Test Plan

Unit tests

References

@edulop91 edulop91 requested a review from a team as a code owner May 12, 2021 16:50
@edulop91 edulop91 requested a review from alldoami May 12, 2021 16:50
cziie
cziie reviewed May 12, 2021
View reviewed changes
pkg/resources/user_public_keys.go Outdated Show resolved Hide resolved
pkg/resources/user_public_keys.go Outdated Show resolved Hide resolved
@github-actions
Copy link

Integration tests failure for 753ffcd02bcb5867a719374ccec3454c420d8795

@github-actions
Copy link

Integration tests failure for 15d6480cd8369d31600f5ebd87a25cee0ec0964c

@github-actions
Copy link

Integration tests success for 9de687bce342358641d12115fea9a49e29f5d1bb

cziie
cziie reviewed May 12, 2021
View reviewed changes
pkg/resources/user_public_keys_acceptance_test.go
sshkey2, err := testhelpers.Fixture("userkey2")
r.NoError(err)

resource.ParallelTest(t, resource.TestCase{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[tfproviderlint] reported by reviewdog 🐶
AT001: missing CheckDestroy

@github-actions
Copy link

Integration tests failure for 00bbb3376046bfbb5a7143b8c2dec2ddffc697b1

@github-actions
Copy link

Integration tests failure for 7506e880d57746a4ddd711ca82a76ac75592c705

@github-actions
Copy link

Integration tests failure for 6193d6d77d40ae20ddaa5eec2bc3438d09667498

@github-actions
Copy link

Integration tests failure for 9b397910dc834081bb4986257fafddb2db2d119e

@github-actions
Copy link

Integration tests failure for 19f30ee63602e3f238ed511ebc6ed076594e3622

@github-actions
Copy link

Integration tests failure for 426e10ec0752f76500a95402f691193e6ad7825b

@github-actions
Copy link

Integration tests success for f867d2f77815de965c64224011d33dec0780cc1e

@github-actions
Copy link

Integration tests success for 366dd0fe391fb4e37c953c0afe41ef3f5da33b03

@czimergebot czimergebot merged commit 590c22e into main May 12, 2021
@czimergebot czimergebot deleted the edu/user-keys branch May 12, 2021 19:39
anton-chekanov pushed a commit to anton-chekanov/terraform-provider-snowflake that referenced this pull request Jan 25, 2022
@anton-chekanov
feat: Resource to manage a user's public keys (Snowflake-Labs#540)
247289c 
<!-- Feel free to delete comments as you fill this in -->

<!-- summary of changes -->
A resource to manage a user's public keys. Note that this resource is intended to be used when users are managed through an external source (eg SCIM) and it'll conflict with the `snowflake_user` resource.

## Test Plan
Unit tests

## References
daniepett pushed a commit to daniepett/terraform-provider-snowflake that referenced this pull request Feb 9, 2022
feat: Resource to manage a user's public keys (Snowflake-Labs#540)
6b1af27 
<!-- Feel free to delete comments as you fill this in -->

<!-- summary of changes -->
A resource to manage a user's public keys. Note that this resource is intended to be used when users are managed through an external source (eg SCIM) and it'll conflict with the `snowflake_user` resource.

## Test Plan
Unit tests

## References
@snowflake-release-please snowflake-release-please bot mentioned this pull request May 25, 2022
Merged
This was referenced Nov 1, 2022
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cziie cziie cziie left review comments

@alldoami alldoami alldoami approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@edulop91 @alldoami @cziie @czimergebot