feat: add STORAGE_AWS_OBJECT_ACL support to storage integration #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faultymonk
changed the title
faultymonk
changed the title
|
/ok-to-test sha=6557ace |
|
run |
|
Integration tests success for 6557ace |
|
could you merge from |
|
/ok-to-test sha=a193d9e |
|
Integration tests success for a193d9e |
alldoami
approved these changes
Nov 10, 2021
daniepett
pushed a commit
to daniepett/terraform-provider-snowflake
that referenced
this pull request
Feb 9, 2022
This was referenced Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
STORAGE_AWS_OBJECT_ACLsupport to the storage integration.Also added
COMMENTtoReadStorageIntegration- noticed from warnings thrown while debugging acceptance testing.Test Plan
References