fix: sequence import #775
Merged
fix: sequence import #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtzero
force-pushed
the
fix-sequence-import
branch
from
bb62bdb
to
b3506d7
Compare
jtzero
force-pushed
the
fix-sequence-import
branch
3 times, most recently
from
db3350d
to
937058f
Compare
|
/ok-to-test sha=937058f |
|
Integration tests failure for 937058f |
|
well that's a bummer, looks as though something got lost in a merge in the old repo, WIP |
jtzero
force-pushed
the
fix-sequence-import
branch
from
937058f
to
3163818
Compare
jtzero
force-pushed
the
fix-sequence-import
branch
5 times, most recently
from
296d39f
to
907b57c
Compare
|
this should be ready to go now |
jtzero
force-pushed
the
fix-sequence-import
branch
from
907b57c
to
e901b85
Compare
|
@alldoami at your convenience |
jtzero
force-pushed
the
fix-sequence-import
branch
3 times, most recently
from
116be17
to
480bb46
Compare
2 tasks
jtzero
force-pushed
the
fix-sequence-import
branch
from
480bb46
to
330205f
Compare
jtzero
force-pushed
the
fix-sequence-import
branch
2 times, most recently
from
3bea04d
to
6dcefa6
Compare
|
no changes just rebasing to keep up to date |
jtzero
force-pushed
the
fix-sequence-import
branch
2 times, most recently
from
84b2fdd
to
63277b8
Compare
|
no changes just rebasing to keep up to date |
|
/ok-to-test sha=63277b8 |
|
Integration tests success for 63277b8 |
|
Sweet! Could you update your branch and we can get this merged? Sorry I don't remember seeing updates on my side! |
jtzero
force-pushed
the
fix-sequence-import
branch
2 times, most recently
from
63277b8
to
2ad4197
Compare
|
np! |
jtzero
force-pushed
the
fix-sequence-import
branch
from
2ad4197
to
1708eab
Compare
|
/ok-to-test sha=1708eab |
|
Integration tests success for 1708eab |
alldoami
approved these changes
Mar 14, 2022
This was referenced Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also a database/schema change to
https://github.com/chanzuckerberg/terraform-provider-snowflake/blob/db3350d5c9e0a641e80f6c2803c5364658d49584/pkg/resources/sequence.go#L44-L50
as that is what's happening behind the scenes, however it does copy over the current sequence value
https://github.com/chanzuckerberg/terraform-provider-snowflake/blob/b3506d7fd2f3d548a128693d94bc87714492dd83/pkg/resources/sequence.go#L221-L236
Test Plan
existing tests pass changing only the format to include both the database and schema
References