feat: Add 'snowflake_role' datasource #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok-to-test sha=703366f |
|
Integration tests failure for 703366f |
|
Test failures seem unrelated to this PR but will take a look |
|
Test for NotificationIntegration resource was failing as the plan tries to set the DIRECTION to NULL after the first test step, but in Snowflake this seems to default to INBOUND |
|
/ok-to-test sha=3a55049 |
|
Integration tests failure for 3a55049 |
|
appears I misunderstood the Azure integration so have updated the GCP part of the test instead |
|
/ok-to-test sha=a0719d9 |
|
Integration tests success for a0719d9 |
alldoami
approved these changes
Apr 28, 2022
This was referenced Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds functionality to use snowflake_role as a datasource
Test Plan
References