Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing tolerances of compare functions #367

Open
plerouxanyon opened this issue Jan 31, 2024 · 0 comments
Open

Allow changing tolerances of compare functions #367

plerouxanyon opened this issue Jan 31, 2024 · 0 comments

Comments

@plerouxanyon
Copy link
Collaborator

plerouxanyon commented Jan 31, 2024

Overview

We provide compare functions to compare equivalence quickly while ignoring the global phase. The problem is that the tolerances are not one-size-fits-all. The default tolerances might be too tight depending on how many operations are performed. We can't loosen it up too much, either. Since then, the default tolerances will be too loose! We should allow the caller to specify if they need a different accuracy and default to the defaults of isapprox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant