Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix action issue #216

Merged
merged 8 commits into from
Jun 22, 2021
Merged

Conversation

sebastianrath
Copy link
Contributor

@sebastianrath sebastianrath commented Jun 19, 2021

The failing unit-test creates 2 files. If there is a hash collision of the first 2 or 4 digits between the 2 files, we get 2 (or respectively 1) directory less, and therefore we might get 22 or 23 items in the common dir, rather than 24.

Fix for #215

@sebastianrath sebastianrath marked this pull request as draft June 19, 2021 18:15
@sebastianrath sebastianrath marked this pull request as ready for review June 22, 2021 05:12
@sebastianrath sebastianrath merged commit 0deb12f into snowtrack:main Jun 22, 2021
@sebastianrath sebastianrath deleted the bugfix/failed-unit-test branch June 22, 2021 05:13
@sebastianrath sebastianrath linked an issue Jun 22, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit-test expects 24 items but receives 23
1 participant