-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check visual regression fails #301
Comments
Any updates on this? |
Sorry for the delayed response. This feature is sort of experimental. We built it in as sort of a proof of concept to see how it might work. We have talked about removing it entirely because we don't have the time or resources to really make it great. We decided to leave it in as long as it continues to work or if there were community members that would like to take on the development and maintenance of it. If it is not currently working, we'd be happy to take a pull request if you want to put some effort into it. If not, we will likely remove it. Hopefully you can help make it great! |
I made a pull request for this. It's a small change in the puppeteer code. Can you please review and merge it? |
Thanks for the contribution. We will get it merged in tomorrow morning PST. |
Running angular-playground 9.0.0
Versions
Repro steps
Observed Behavior
Desired Behavior
Any other details that may be useful (optional)
The text was updated successfully, but these errors were encountered: