Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom builder #309

Open
oschlegel opened this issue Mar 4, 2022 · 1 comment
Open

Custom builder #309

oschlegel opened this issue Mar 4, 2022 · 1 comment

Comments

@oschlegel
Copy link
Contributor

oschlegel commented Mar 4, 2022

Angular provides the possibility to extend the default builders by wrapping it with a custom builder. This means that the angular playground package could provide a custom builder for the build, serve and possibly even additional commands which are custom to angular playground like check-errors. These builders could include the logic which is currently included in the angular playground cli and therefore eliminate the need for the angular playground cli. This could also eliminate the need for angular-playground.json since the configuration for the playground could then be placed in the configuration of the build command in the angular.json.

Using the native angular cli commands instead of a custom cli would make the angular playground more intuitive and easier to use. Another benefit would be that in multi project workspaces the angular playground would be easier to integrate in continuous integration workflows.

Please let me know what you think of the idea, of if you already discussed a similar approach.

@lurock
Copy link
Contributor

lurock commented Mar 8, 2022

This is something we have discussed before and are interested in making these changes. It would be awesome if this is something you would like to work on and submit us a pull request with the changes. At this time we just don't have the time or resources to do it ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants