Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

Converting the project to cspoj #11

Closed
alltej opened this issue Jan 19, 2017 · 8 comments
Closed

Converting the project to cspoj #11

alltej opened this issue Jan 19, 2017 · 8 comments

Comments

@alltej
Copy link
Contributor

alltej commented Jan 19, 2017

Since the xproj and project.sjon are going away for .NET core, it might make sense to convert the project to csproj. What you think?

@loekd
Copy link
Collaborator

loekd commented Jan 20, 2017

I totally agree. My idea was to do that once VS2015 tools come out of preview, or when VS2017 goes RTM. Do you need it sooner?

@alltej
Copy link
Contributor Author

alltej commented Jan 20, 2017

Not really. The reason being I want to project reference the ServiceFabric.PubSubActors and ServiceFabric.PubSubActors.Interfaces projects from the demo project so I can step through it. But looks like nuget manager is not finding it because they are xproj. Let me know if there is another work around. Thanks

@alltej
Copy link
Contributor Author

alltej commented Jan 20, 2017

Ignore about referencing the libraries. I got it work.

@loekd
Copy link
Collaborator

loekd commented Jan 22, 2017

For any other readers that want to debug, you don't need a project reference.

Symbols are published here: http://www.symbolsource.org/Public/Home/VisualStudio
Manually open the file you want to debug, and put a breakpoint.

Option two would be to install .net core on your machine, compile the project to get the PDB's and manually load symbols using the Debug->Windows ->Modules window in Visual Studio.

@alltej
Copy link
Contributor Author

alltej commented Jan 24, 2017

@loekd If I need to modify some code in the package(ServiceFabric.PubSubActors) itself, so I think I need to project reference the package code from the demo project, so I can step through the modified code. So not sure if I am setting up my environment correctly for this project.

@loekd
Copy link
Collaborator

loekd commented Jan 24, 2017

Changing the code is a lot easier with project references indeed.

@loekd
Copy link
Collaborator

loekd commented Jun 8, 2017

@alltej I've converted to VS2017 & csproj files.

@alltej
Copy link
Contributor Author

alltej commented Jun 8, 2017

thanks for converting it! also thanks for accepting my PR :)

@alltej alltej closed this as completed Jun 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants