Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After upgrade to Kaos 6a underscores are not added during page create #20

Open
macin opened this issue Mar 9, 2024 · 1 comment
Open

Comments

@macin
Copy link

macin commented Mar 9, 2024

See thread on main dokuwiki GitHub. I am using page buttons to create pages inside my instance of dokuwiki.

dokuwiki/dokuwiki#4238

@fiwswe
Copy link

fiwswe commented Mar 9, 2024

Disclaimer: I have never used this plugin myself.

var submit_url = pre_url + urlSeparator + page + "&do=edit";
window.location.href = submit_url;

and

var submit_url = pre_url + urlSeparator + newpage + "&do=edit";
window.location.href = submit_url

show that an URL is constructed that contains the literal string of the page name that the user entered, including spaces or other special characters and then the browser is instructed to redirect to that URL. Since spaces are illegal in URLs they are converted to %20 by the browser.

This does not seem to have changed and there seems no relation to the DokuWiki "Kaos" release. This was always broken.

In order to respect DokuWiki's sepchar setting, and potentially other code in DokuWiki used to convert user input to page IDs, there would need to be major changes made to this plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants