Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icicle): fix buggy overlay on icicle zoom #1204

Merged
merged 1 commit into from Feb 24, 2021
Merged

Conversation

Alezco
Copy link
Contributor

@Alezco Alezco commented Feb 24, 2021

No description provided.

@Alezco Alezco requested a review from cberthou February 24, 2021 10:44
@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #1204 (02cbc34) into feat/zoom (0c8bdcd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           feat/zoom    #1204   +/-   ##
==========================================
  Coverage      80.13%   80.13%           
==========================================
  Files            124      124           
  Lines           3086     3086           
  Branches         408      408           
==========================================
  Hits            2473     2473           
  Misses           610      610           
  Partials           3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c8bdcd...0951ce5. Read the comment docs.

@Alezco Alezco merged commit 2816dff into feat/zoom Feb 24, 2021
@Alezco Alezco deleted the fix-icicle-overlay branch February 24, 2021 10:49
Alezco added a commit that referenced this pull request Apr 2, 2021
* feat(icicles): add zoom on icicles (#1197)

* feat(zoom): add zoom buttons in navigation bar (#1203)

* fix(icicle): fix buggy overlay on icicle zoom (#1204)

* fix(zoom): fix double click zoom (#1205)

* feat(zoom): add zoom on selected icicle with navigation bar button (#1212)

* chore(zoom): misc zoom upates (#1213)

* feat(zoom): add zoom tracking (#1224)
github-actions bot pushed a commit that referenced this pull request Apr 14, 2021
# [3.2.0](v3.1.1...v3.2.0) (2021-04-14)

### Bug Fixes

* **deletion-script:** fix script encoding on windows ([#1253](#1253)) ([c4b69e4](c4b69e4))
* fix csv export on windows ([#1250](#1250)) ([112466e](112466e))
* fix deletion script when there is a space in the root path ([#1252](#1252)) ([8c474c9](8c474c9))
* fix electron not launching ([#1249](#1249)) ([4bf32c7](4bf32c7))
* fix windows deletion script ([#1251](#1251)) ([d602a94](d602a94))
* **background-loading-info:** fix z-index ([#1139](#1139)) ([b3ebbcd](b3ebbcd))
* **deps:** update all dependencies ([#1142](#1142)) ([188b53d](188b53d))
* **deps:** update all dependencies ([#1155](#1155)) ([50da2cb](50da2cb))
* **deps:** update all dependencies ([#1166](#1166)) ([b1cd7e6](b1cd7e6))
* **deps:** update all dependencies ([#1174](#1174)) ([c356a70](c356a70))
* **deps:** update all dependencies ([#1207](#1207)) ([fae80c5](fae80c5))
* **deps:** update all dependencies ([#1216](#1216)) ([8f3d4fd](8f3d4fd))
* **deps:** update all non-major dependencies ([#1145](#1145)) ([5aaf0cc](5aaf0cc))
* **deps:** update all non-major dependencies ([#1175](#1175)) ([ca9c15f](ca9c15f))
* **deps:** update dependency @sentry/browser to v6 ([#1239](#1239)) ([ca8d473](ca8d473))
* **husky:** fix husky after dependency update ([#1240](#1240)) ([4e1b5ff](4e1b5ff))
* **pagination:** add pagination reset on new search ([#1245](#1245)) ([2f8610a](2f8610a))
* **resip:** fix browse all being applied  on resip export ([#1196](#1196)) ([2eabd51](2eabd51))
* **search:** fix search modal csv export on to delete column ([#1246](#1246)) ([6041cde](6041cde))
* **search:** fix search modal filter menu position ([#1244](#1244)) ([b1302d8](b1302d8))
* **tracking:** fix matomo tracking ([#1225](#1225)) ([ef5ae9b](ef5ae9b))
* add translations for loading screen error message ([#1152](#1152)) ([fc2b412](fc2b412))
* fix hash computing errors not being displayed ([#1189](#1189)) ([0fc7336](0fc7336))
* fix loading of older versions of the script file ([#1124](#1124)) ([6c2c67b](6c2c67b))
* fix production bug caused by worker refactoring ([#1160](#1160)) ([dec7842](dec7842))
* fix scroll bars on loading screen ([#1128](#1128)) ([e256f2f](e256f2f))
* invert size and last modified date on linux import script ([#1186](#1186)) ([31a85b7](31a85b7))
* remove javascript rejected promise error in console ([#1161](#1161)) ([293d2b8](293d2b8))
* stream data between child and main process to prevent memory overload([#1157](#1157)) ([b9e5512](b9e5512))
* **github:** unify behaviour of release channels ([003abbd](003abbd))
* run branch builds on pull requests ([#1118](#1118)) ([1e0b306](1e0b306))

### Features

* **audit:** add notification on audit report ([#1231](#1231)) ([73f8850](73f8850))
* **dropzone:** add error notification when multiple folders are dropped ([#1141](#1141)) ([8dfcd24](8dfcd24))
* **duplicates-table:** collapse accordions on page change ([#1255](#1255)) ([a4ef1cc](a4ef1cc))
* **error-screen:** add reload button on error screen ([#1140](#1140)) ([3961b76](3961b76))
* **export:** add select all in export modal ([#1192](#1192)) ([2806550](2806550))
* **github:** allow manual build trigged on github ([#1120](#1120)) ([792f3cf](792f3cf)), closes [#1095](#1095) [#1010](#1010) [#1121](#1121)
* **hashes:** add release hashes in pipeline ([#1156](#1156)) ([a8c90ea](a8c90ea)), closes [#1139](#1139) [#1142](#1142) [#1155](#1155) [#1145](#1145) [#1124](#1124) [#1128](#1128) [#1118](#1118) [#1149](#1149) [#1141](#1141) [#1140](#1140) [#1146](#1146) [#1126](#1126) [#1129](#1129) [#1095](#1095) [#1010](#1010) [#1121](#1121)
* **help:** add help button in main space ([#1223](#1223)) ([efc3268](efc3268))
* **icicles:** add zoom on icicles ([#1197](#1197)) ([#1198](#1198)) ([f9ba117](f9ba117)), closes [#1203](#1203) [#1204](#1204) [#1205](#1205) [#1212](#1212) [#1213](#1213) [#1224](#1224)
* **sentry:** anonymize sentry data ([ed0c2ad](ed0c2ad))
* **settings:** add email address in settings modal ([#1243](#1243)) ([0a7283e](0a7283e))
* **settings:** add more links in settings modal ([#1187](#1187)) ([3a7af39](3a7af39))
* **signing:** add code signing certificate for Windows ([#1154](#1154)) ([45cb612](45cb612))
* **start-screen:** add error message when invalid path loaded ([#1146](#1146)) ([342fac0](342fac0))
* **survey:** update survey link ([#1219](#1219)) ([03d8b2f](03d8b2f))
* **table:** scroll to the top on table page change ([#1254](#1254)) ([3960903](3960903))
* **tracking:** add more matomo events ([#1221](#1221)) ([e66bb51](e66bb51))
* **tracking:** anonymize Matomo data ([#1170](#1170)) ([c2c06d9](c2c06d9))
* **zoom:** invert zoom wheel direction ([#1242](#1242)) ([49464cf](49464cf))
* add deletion script ([#1227](#1227)) ([532b1d5](532b1d5))
* add last modified dates to CSV export ([#1195](#1195)) ([26c711e](26c711e))
* allow to edit element date ([#1126](#1126)) ([02d0939](02d0939))
* allow to save and load updated dates ([#1129](#1129)) ([8b856ba](8b856ba))
* improve file system loading error handling ([#1149](#1149)) ([e07e2c4](e07e2c4))
lsagetlethias pushed a commit that referenced this pull request Apr 1, 2022
* feat(icicles): add zoom on icicles (#1197)

* feat(zoom): add zoom buttons in navigation bar (#1203)

* fix(icicle): fix buggy overlay on icicle zoom (#1204)

* fix(zoom): fix double click zoom (#1205)

* feat(zoom): add zoom on selected icicle with navigation bar button (#1212)

* chore(zoom): misc zoom upates (#1213)

* feat(zoom): add zoom tracking (#1224)
lsagetlethias pushed a commit that referenced this pull request Apr 1, 2022
# [3.2.0](v3.1.1...v3.2.0) (2021-04-14)

### Bug Fixes

* **deletion-script:** fix script encoding on windows ([#1253](#1253)) ([c4b69e4](c4b69e4))
* fix csv export on windows ([#1250](#1250)) ([112466e](112466e))
* fix deletion script when there is a space in the root path ([#1252](#1252)) ([8c474c9](8c474c9))
* fix electron not launching ([#1249](#1249)) ([4bf32c7](4bf32c7))
* fix windows deletion script ([#1251](#1251)) ([d602a94](d602a94))
* **background-loading-info:** fix z-index ([#1139](#1139)) ([b3ebbcd](b3ebbcd))
* **deps:** update all dependencies ([#1142](#1142)) ([188b53d](188b53d))
* **deps:** update all dependencies ([#1155](#1155)) ([50da2cb](50da2cb))
* **deps:** update all dependencies ([#1166](#1166)) ([b1cd7e6](b1cd7e6))
* **deps:** update all dependencies ([#1174](#1174)) ([c356a70](c356a70))
* **deps:** update all dependencies ([#1207](#1207)) ([fae80c5](fae80c5))
* **deps:** update all dependencies ([#1216](#1216)) ([8f3d4fd](8f3d4fd))
* **deps:** update all non-major dependencies ([#1145](#1145)) ([5aaf0cc](5aaf0cc))
* **deps:** update all non-major dependencies ([#1175](#1175)) ([ca9c15f](ca9c15f))
* **deps:** update dependency @sentry/browser to v6 ([#1239](#1239)) ([ca8d473](ca8d473))
* **husky:** fix husky after dependency update ([#1240](#1240)) ([4e1b5ff](4e1b5ff))
* **pagination:** add pagination reset on new search ([#1245](#1245)) ([2f8610a](2f8610a))
* **resip:** fix browse all being applied  on resip export ([#1196](#1196)) ([2eabd51](2eabd51))
* **search:** fix search modal csv export on to delete column ([#1246](#1246)) ([6041cde](6041cde))
* **search:** fix search modal filter menu position ([#1244](#1244)) ([b1302d8](b1302d8))
* **tracking:** fix matomo tracking ([#1225](#1225)) ([ef5ae9b](ef5ae9b))
* add translations for loading screen error message ([#1152](#1152)) ([fc2b412](fc2b412))
* fix hash computing errors not being displayed ([#1189](#1189)) ([0fc7336](0fc7336))
* fix loading of older versions of the script file ([#1124](#1124)) ([6c2c67b](6c2c67b))
* fix production bug caused by worker refactoring ([#1160](#1160)) ([dec7842](dec7842))
* fix scroll bars on loading screen ([#1128](#1128)) ([e256f2f](e256f2f))
* invert size and last modified date on linux import script ([#1186](#1186)) ([31a85b7](31a85b7))
* remove javascript rejected promise error in console ([#1161](#1161)) ([293d2b8](293d2b8))
* stream data between child and main process to prevent memory overload([#1157](#1157)) ([b9e5512](b9e5512))
* **github:** unify behaviour of release channels ([003abbd](003abbd))
* run branch builds on pull requests ([#1118](#1118)) ([1e0b306](1e0b306))

### Features

* **audit:** add notification on audit report ([#1231](#1231)) ([73f8850](73f8850))
* **dropzone:** add error notification when multiple folders are dropped ([#1141](#1141)) ([8dfcd24](8dfcd24))
* **duplicates-table:** collapse accordions on page change ([#1255](#1255)) ([a4ef1cc](a4ef1cc))
* **error-screen:** add reload button on error screen ([#1140](#1140)) ([3961b76](3961b76))
* **export:** add select all in export modal ([#1192](#1192)) ([2806550](2806550))
* **github:** allow manual build trigged on github ([#1120](#1120)) ([792f3cf](792f3cf)), closes [#1095](#1095) [#1010](#1010) [#1121](#1121)
* **hashes:** add release hashes in pipeline ([#1156](#1156)) ([a8c90ea](a8c90ea)), closes [#1139](#1139) [#1142](#1142) [#1155](#1155) [#1145](#1145) [#1124](#1124) [#1128](#1128) [#1118](#1118) [#1149](#1149) [#1141](#1141) [#1140](#1140) [#1146](#1146) [#1126](#1126) [#1129](#1129) [#1095](#1095) [#1010](#1010) [#1121](#1121)
* **help:** add help button in main space ([#1223](#1223)) ([efc3268](efc3268))
* **icicles:** add zoom on icicles ([#1197](#1197)) ([#1198](#1198)) ([f9ba117](f9ba117)), closes [#1203](#1203) [#1204](#1204) [#1205](#1205) [#1212](#1212) [#1213](#1213) [#1224](#1224)
* **sentry:** anonymize sentry data ([ed0c2ad](ed0c2ad))
* **settings:** add email address in settings modal ([#1243](#1243)) ([0a7283e](0a7283e))
* **settings:** add more links in settings modal ([#1187](#1187)) ([3a7af39](3a7af39))
* **signing:** add code signing certificate for Windows ([#1154](#1154)) ([45cb612](45cb612))
* **start-screen:** add error message when invalid path loaded ([#1146](#1146)) ([342fac0](342fac0))
* **survey:** update survey link ([#1219](#1219)) ([03d8b2f](03d8b2f))
* **table:** scroll to the top on table page change ([#1254](#1254)) ([3960903](3960903))
* **tracking:** add more matomo events ([#1221](#1221)) ([e66bb51](e66bb51))
* **tracking:** anonymize Matomo data ([#1170](#1170)) ([c2c06d9](c2c06d9))
* **zoom:** invert zoom wheel direction ([#1242](#1242)) ([49464cf](49464cf))
* add deletion script ([#1227](#1227)) ([532b1d5](532b1d5))
* add last modified dates to CSV export ([#1195](#1195)) ([26c711e](26c711e))
* allow to edit element date ([#1126](#1126)) ([02d0939](02d0939))
* allow to save and load updated dates ([#1129](#1129)) ([8b856ba](8b856ba))
* improve file system loading error handling ([#1149](#1149)) ([e07e2c4](e07e2c4))
TimotheeMalard pushed a commit that referenced this pull request Dec 29, 2023
* feat(icicles): add zoom on icicles (#1197)

* feat(zoom): add zoom buttons in navigation bar (#1203)

* fix(icicle): fix buggy overlay on icicle zoom (#1204)

* fix(zoom): fix double click zoom (#1205)

* feat(zoom): add zoom on selected icicle with navigation bar button (#1212)

* chore(zoom): misc zoom upates (#1213)

* feat(zoom): add zoom tracking (#1224)
TimotheeMalard pushed a commit that referenced this pull request Dec 29, 2023
# [3.2.0](v3.1.1...v3.2.0) (2021-04-14)

### Bug Fixes

* **deletion-script:** fix script encoding on windows ([#1253](#1253)) ([c4b69e4](c4b69e4))
* fix csv export on windows ([#1250](#1250)) ([112466e](112466e))
* fix deletion script when there is a space in the root path ([#1252](#1252)) ([8c474c9](8c474c9))
* fix electron not launching ([#1249](#1249)) ([4bf32c7](4bf32c7))
* fix windows deletion script ([#1251](#1251)) ([d602a94](d602a94))
* **background-loading-info:** fix z-index ([#1139](#1139)) ([b3ebbcd](b3ebbcd))
* **deps:** update all dependencies ([#1142](#1142)) ([188b53d](188b53d))
* **deps:** update all dependencies ([#1155](#1155)) ([50da2cb](50da2cb))
* **deps:** update all dependencies ([#1166](#1166)) ([b1cd7e6](b1cd7e6))
* **deps:** update all dependencies ([#1174](#1174)) ([c356a70](c356a70))
* **deps:** update all dependencies ([#1207](#1207)) ([fae80c5](fae80c5))
* **deps:** update all dependencies ([#1216](#1216)) ([8f3d4fd](8f3d4fd))
* **deps:** update all non-major dependencies ([#1145](#1145)) ([5aaf0cc](5aaf0cc))
* **deps:** update all non-major dependencies ([#1175](#1175)) ([ca9c15f](ca9c15f))
* **deps:** update dependency @sentry/browser to v6 ([#1239](#1239)) ([ca8d473](ca8d473))
* **husky:** fix husky after dependency update ([#1240](#1240)) ([4e1b5ff](4e1b5ff))
* **pagination:** add pagination reset on new search ([#1245](#1245)) ([2f8610a](2f8610a))
* **resip:** fix browse all being applied  on resip export ([#1196](#1196)) ([2eabd51](2eabd51))
* **search:** fix search modal csv export on to delete column ([#1246](#1246)) ([6041cde](6041cde))
* **search:** fix search modal filter menu position ([#1244](#1244)) ([b1302d8](b1302d8))
* **tracking:** fix matomo tracking ([#1225](#1225)) ([ef5ae9b](ef5ae9b))
* add translations for loading screen error message ([#1152](#1152)) ([fc2b412](fc2b412))
* fix hash computing errors not being displayed ([#1189](#1189)) ([0fc7336](0fc7336))
* fix loading of older versions of the script file ([#1124](#1124)) ([6c2c67b](6c2c67b))
* fix production bug caused by worker refactoring ([#1160](#1160)) ([dec7842](dec7842))
* fix scroll bars on loading screen ([#1128](#1128)) ([e256f2f](e256f2f))
* invert size and last modified date on linux import script ([#1186](#1186)) ([31a85b7](31a85b7))
* remove javascript rejected promise error in console ([#1161](#1161)) ([293d2b8](293d2b8))
* stream data between child and main process to prevent memory overload([#1157](#1157)) ([b9e5512](b9e5512))
* **github:** unify behaviour of release channels ([003abbd](003abbd))
* run branch builds on pull requests ([#1118](#1118)) ([1e0b306](1e0b306))

### Features

* **audit:** add notification on audit report ([#1231](#1231)) ([73f8850](73f8850))
* **dropzone:** add error notification when multiple folders are dropped ([#1141](#1141)) ([8dfcd24](8dfcd24))
* **duplicates-table:** collapse accordions on page change ([#1255](#1255)) ([a4ef1cc](a4ef1cc))
* **error-screen:** add reload button on error screen ([#1140](#1140)) ([3961b76](3961b76))
* **export:** add select all in export modal ([#1192](#1192)) ([2806550](2806550))
* **github:** allow manual build trigged on github ([#1120](#1120)) ([792f3cf](792f3cf)), closes [#1095](#1095) [#1010](#1010) [#1121](#1121)
* **hashes:** add release hashes in pipeline ([#1156](#1156)) ([a8c90ea](a8c90ea)), closes [#1139](#1139) [#1142](#1142) [#1155](#1155) [#1145](#1145) [#1124](#1124) [#1128](#1128) [#1118](#1118) [#1149](#1149) [#1141](#1141) [#1140](#1140) [#1146](#1146) [#1126](#1126) [#1129](#1129) [#1095](#1095) [#1010](#1010) [#1121](#1121)
* **help:** add help button in main space ([#1223](#1223)) ([efc3268](efc3268))
* **icicles:** add zoom on icicles ([#1197](#1197)) ([#1198](#1198)) ([f9ba117](f9ba117)), closes [#1203](#1203) [#1204](#1204) [#1205](#1205) [#1212](#1212) [#1213](#1213) [#1224](#1224)
* **sentry:** anonymize sentry data ([ed0c2ad](ed0c2ad))
* **settings:** add email address in settings modal ([#1243](#1243)) ([0a7283e](0a7283e))
* **settings:** add more links in settings modal ([#1187](#1187)) ([3a7af39](3a7af39))
* **signing:** add code signing certificate for Windows ([#1154](#1154)) ([45cb612](45cb612))
* **start-screen:** add error message when invalid path loaded ([#1146](#1146)) ([342fac0](342fac0))
* **survey:** update survey link ([#1219](#1219)) ([03d8b2f](03d8b2f))
* **table:** scroll to the top on table page change ([#1254](#1254)) ([3960903](3960903))
* **tracking:** add more matomo events ([#1221](#1221)) ([e66bb51](e66bb51))
* **tracking:** anonymize Matomo data ([#1170](#1170)) ([c2c06d9](c2c06d9))
* **zoom:** invert zoom wheel direction ([#1242](#1242)) ([49464cf](49464cf))
* add deletion script ([#1227](#1227)) ([532b1d5](532b1d5))
* add last modified dates to CSV export ([#1195](#1195)) ([26c711e](26c711e))
* allow to edit element date ([#1126](#1126)) ([02d0939](02d0939))
* allow to save and load updated dates ([#1129](#1129)) ([8b856ba](8b856ba))
* improve file system loading error handling ([#1149](#1149)) ([e07e2c4](e07e2c4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants