Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): retrait du composant OverflowWrapper dont nous n'avons plus l'utilité (mais qui provoque des erreurs côté client) #5753

Merged
merged 5 commits into from
Apr 9, 2024

Conversation

carolineBda
Copy link
Contributor

@carolineBda carolineBda commented Apr 4, 2024

Fix #5649

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@@ -33,9 +27,7 @@ export const Collapse = ({
type="button"
>
<AccordionArrow aria-hidden="true" />
<StyledText noMargin fontSize="hsmall" fontWeight="600" {...textProps}>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

j'ai cleané ça parce que ces properties n'existent pas sur les span ça fait des erreurs html

@@ -1,18 +0,0 @@
import PropTypes from "prop-types";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je l'ai supprimé parce qu'on ne l'utilise pas

@carolineBda carolineBda requested review from maxgfr, m-maillot and Viczei and removed request for maxgfr and m-maillot April 8, 2024 12:05
Copy link
Member

@maxgfr maxgfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trop bien !

@carolineBda carolineBda merged commit 8ce9b1c into dev Apr 9, 2024
25 checks passed
@carolineBda carolineBda deleted the carolineBda/remove-overflow-wrapper branch April 9, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investiguer utilisation du composant OverflowWrapper et le retirer
4 participants