fix(indemnite-licenciement): ajout de log + tests sur les années #5798
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
maxgfr
changed the title
There was a problem hiding this comment.
En gros, ici, c'est là où on debuggera les bugs issues de Sentry
| const month = splitParts[1] ?? ""; | ||
| const year = splitParts[2] ?? ""; | ||
| if (year.length === 2) { | ||
| baseDate = `${day}/${month}/${year < 50 ? `20${year}` : `19${year}`}`; |
There was a problem hiding this comment.
J'ai pris 50, ça me semblait pertinent, pour pouvoir mettre des dates futures
There was a problem hiding this comment.
idéalement il faut prendre les 2 derniers digits de la current year non ?
| } | ||
| setDate(baseDate); | ||
| setIsValid(isValidDate(baseDate)); |
|
Un point à valider concerne l'accessibilité, je ne suis pas sûr qu'en faisant cela le composant soit accessible 👀 |
maxgfr
changed the title
|
🎉 Deployment for commit 3e140c5 : IngressesDocker images
|
fix #5718