Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): modification du test e2e integration afin d'enlever les failure aléatoires #5847

Merged
merged 3 commits into from
May 7, 2024

Conversation

carolineBda
Copy link
Contributor

@carolineBda carolineBda commented May 6, 2024

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@@ -0,0 +1,41 @@
Cypress.Commands.add("getIframe" as any, () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finalement c'est en isolant le test dans un autre fichier que ça l'a fixé. je crois que ça vient du fait qu'on définissait 2 fois le même spy dans 2 test différent

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

j'ai déjà eu ce soucis là sur la landing à l'époque....

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La solution c'est faire dans des fichiers séparés

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est d'ailleurs pour ça que j'avais fait plusieurs fichiers séparés au début

@@ -0,0 +1,41 @@
Cypress.Commands.add("getIframe" as any, () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

j'ai déjà eu ce soucis là sur la landing à l'époque....

@@ -0,0 +1,41 @@
Cypress.Commands.add("getIframe" as any, () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La solution c'est faire dans des fichiers séparés

@carolineBda carolineBda merged commit 7e5ad15 into dev May 7, 2024
24 checks passed
@carolineBda carolineBda deleted the carolineBda/fix-e2e-integration branch May 7, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants