Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): ajout des tests dans les sous dossiers #5879

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

m-maillot
Copy link
Contributor

No description provided.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

MATTERMOST_WEBHOOK_URL: ${{ secrets.MATTERMOST_WEBHOOK_URL }}
PAYLOAD: |-
{
"text": "Les tests automatiques e2e sont terminés: **${{ job.status }}**. Détails : ${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En attendant de trouver mieux. On envoie toujours le résultat des tests e2e. Si un jour, on ne l'a pas, c'est qu'il y a un problème.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tu peux utiliser le TEXT sinon

- name: Send message to mattermost if failure
uses: mattermost/action-mattermost-notify@master
- name: Send message to mattermost when done
uses: mattermost/action-mattermost-notify@v2.0.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je fige la version en 2.0.0 pour éviter des changements non voulus...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, bien !

if: failure()
with:
MATTERMOST_WEBHOOK_URL: ${{ secrets.MATTERMOST_WEBHOOK_URL }}
PAYLOAD: |-
{
"text": "Tests e2e en échec @max @victorz @carolinebda @martial :scream:",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Si les tests sont en échec, je ping l'équipe. Ca permet de ne pas louper un test e2e en échec dans la masse.

@m-maillot m-maillot marked this pull request as ready for review May 14, 2024 12:38
- name: Send message to mattermost if failure
uses: mattermost/action-mattermost-notify@master
- name: Send message to mattermost when done
uses: mattermost/action-mattermost-notify@v2.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, bien !

MATTERMOST_WEBHOOK_URL: ${{ secrets.MATTERMOST_WEBHOOK_URL }}
PAYLOAD: |-
{
"text": "Les tests automatiques e2e sont terminés: **${{ job.status }}**. Détails : ${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tu peux utiliser le TEXT sinon

Copy link

@m-maillot m-maillot merged commit 682fce9 into dev May 14, 2024
23 checks passed
@m-maillot m-maillot deleted the fix/test-e2e-ci branch May 14, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants