Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove automergeAll #164

Merged
merged 1 commit into from
Sep 24, 2020
Merged

fix: remove automergeAll #164

merged 1 commit into from
Sep 24, 2020

Conversation

revolunet
Copy link
Member

No description provided.

@douglasduteil
Copy link
Contributor

Why because no tests ?

@revolunet
Copy link
Member Author

i think its safer to be aware of major changes and review manually

@douglasduteil
Copy link
Contributor

douglasduteil commented Sep 23, 2020

In the tests you don't trust @revolunet ;)
What are the missing tests that you are reviewing manually ?

@revolunet
Copy link
Member Author

humans > bots

@douglasduteil
Copy link
Contributor

❤️ 🤖 gives :hurtrealbad: ⌚ to 😄 🍺 ☮️

IMO it's better to add more tests to prevent most failing scenario than to spend our time reviewing manually unimpactful prs
Specially on project like this one where the bot is autonomous since the beginning of the year with little impact on the stability

@douglasduteil
Copy link
Contributor

[AFK discussion]

@douglasduteil douglasduteil merged commit 37a3681 into master Sep 24, 2020
@douglasduteil douglasduteil deleted the revolunet-patch-2 branch September 24, 2020 09:48
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 1.38.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants