Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(pkg)!: export cjs and module format #59

Merged

Conversation

douglasduteil
Copy link
Contributor


Help supporting treeshaking

BREAKING CHANGE: export cjs format as main

As most build tools can tree shake commonjs format, I would argue that we should provide the cjs format as default.
The previous bundle is available under the browser entry.

Help supporting treeshaking

BREAKING CHANGE: export cjs format as main

As most build tools can tree shake commonjs format, I would argue that we should provide the cjs format as default.
The previous bundle is available under the `browser` entry.
@douglasduteil douglasduteil self-assigned this Mar 18, 2020
@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #59 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #59   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           16        16           
  Branches         3         3           
=========================================
  Hits            16        16           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 548c0c9...88cf3ed. Read the comment docs.

@revolunet revolunet merged commit 3f82e4d into master Mar 19, 2020
@revolunet revolunet deleted the douglasduteil/build-pkg-export-cjs-and-module-format branch March 19, 2020 10:42
SocialGroovyBot added a commit that referenced this pull request Mar 19, 2020
# [3.0.0](v2.1.1...v3.0.0) (2020-03-19)

* build(pkg)!: export cjs and module format (#59) ([3f82e4d](3f82e4d)), closes [#59](#59)

### Features

* **france:** separate departements functions ([#58](#58)) ([87708a1](87708a1))

### BREAKING CHANGES

* export cjs format as main

As most build tools can tree shake commonjs format, I would argue that we should provide the cjs format as default.
The previous bundle is available under the `browser` entry.
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants