Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: consider react and prop types as peer deps #6

Merged
merged 2 commits into from
Sep 11, 2019
Merged

refactor: consider react and prop types as peer deps #6

merged 2 commits into from
Sep 11, 2019

Conversation

douglasduteil
Copy link
Contributor

@douglasduteil douglasduteil force-pushed the douglasduteil/refactor-consider-react-and-prop-types-as-peerDeps branch from f305b7c to 654c61a Compare September 11, 2019 11:03
@douglasduteil
refactor: consider react and prop-types as peerDeps
1fd80b8 
BREAKING CHANGE: *consider react and prop-types as peerDeps*
  - might affect the published dist
@douglasduteil douglasduteil force-pushed the douglasduteil/refactor-consider-react-and-prop-types-as-peerDeps branch from 654c61a to 1fd80b8 Compare September 11, 2019 11:21
@codecov
Copy link

codecov bot commented Sep 11, 2019 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@a9a21e5). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master     #6   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?      2           
  Lines             ?     16           
  Branches          ?      3           
=======================================
  Hits              ?     16           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9a21e5...af89784. Read the comment docs.

@douglasduteil douglasduteil merged commit 205b2f5 into master Sep 11, 2019
@douglasduteil douglasduteil deleted the douglasduteil/refactor-consider-react-and-prop-types-as-peerDeps branch September 11, 2019 11:31
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revolunet revolunet revolunet approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@douglasduteil @SocialGroovyBot @revolunet