feat(auth): add authentification with keycloak #50

maxgfr · 2022-04-08T17:30:36Z

fix SocialGouv/support#185

DONE :

Ajout d'une page profil où les informations sont accessibles si et seulement l'utilisateur est connecté
Ajout du provider keycloak pour l'authentification
Ajout d'un withAuth qui verifie si le client est connecté côté server side props
Utilisation de next-auth au lieu de react-keycloak
Création du thème avec keycloackify
Création du chart pour keycloack
Mise en place de kube-workflow pour l'app
Mise en place de kube-workflow pour keycloak
Mise en place du français comme langue par défaut
Ajout de FranceConnect 🇫🇷
Documentation qui explique la différence entre la branche main et static

maxgfr · 2022-04-08T17:33:50Z

@revolunet J'ai fait une PR sur main directement. Faudrait-il pas le faire sur une branche à part plutôt ?

revolunet · 2022-04-15T10:05:23Z

Oui je pense qu'on peut faire une branche keycloak pour l'instant

src/components/header/index.tsx

gitguardian · 2022-04-22T15:20:55Z

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
3178153	Generic High Entropy Secret	`b0f9761`	.env.development	View secret
3178153	Generic High Entropy Secret	`6f0625b`	.env.development	View secret
3178153	Generic High Entropy Secret	`ecdcd12`	.env.development	View secret
3178153	Generic High Entropy Secret	`55d8a90`	.env.development	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

gitguardian · 2022-04-22T15:20:55Z

⚠️ GitGuardian has uncovered 14 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
3178153	Generic High Entropy Secret	`b0f9761`	.env.development	View secret
3178153	Generic High Entropy Secret	`6f0625b`	.env.development	View secret
3178153	Generic High Entropy Secret	`ecdcd12`	.env.development	View secret
3178153	Generic High Entropy Secret	`55d8a90`	.env.development	View secret
3178153	Generic High Entropy Secret	`bc39902`	.env.development	View secret
3356537	Generic High Entropy Secret	`65df1ed`	.kube-workflow/templates/realm.configmap.yaml	View secret
3356537	Generic High Entropy Secret	`15a0502`	config/keycloak/realm.json	View secret
3356537	Generic High Entropy Secret	`eb30d43`	config/realm-export.json	View secret
3356537	Generic High Entropy Secret	`70a2cfe`	.kube-workflow/templates/realm.configmap.yaml	View secret
3178153	Generic High Entropy Secret	`2b87cf4`	.env.development	View secret
3178153	Generic High Entropy Secret	`0fca6ea`	.env.development	View secret
3178153	Generic High Entropy Secret	`0fca6ea`	.env.development	View secret
3178153	Generic High Entropy Secret	`cd67c69`	.env.development	View secret
3513932	Generic High Entropy Secret	`cd67c69`	.env.development	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

src/lib/auth.ts

Co-authored-by: Julien Bouquillon <julien.bouquillon@sg.social.gouv.fr>

sonarcloud · 2022-06-09T18:05:46Z

Please retry analysis of this Pull-Request directly on SonarCloud.

Co-authored-by: Julien Bouquillon <julien.bouquillon@sg.social.gouv.fr>

maxgfr · 2022-06-10T08:54:18Z

Le NEXT_PUBLIC_HOST qui est utilisé dans le robots.txt, on le rajoute dans les .env pour exemple ?

On en a besoin au niveau du build, car celui-ci est utilisé pour générer le bon robots.txt du coup je l'ai rajouté au niveau des docker build args

.github/workflows/preproduction.yml

Co-authored-by: Julien Bouquillon <julien.bouquillon@sg.social.gouv.fr>

.github/workflows/preproduction.yml

.github/workflows/review.yml

maxgfr · 2022-06-13T08:03:16Z

Merci pour les retours @revolunet. C'est réglé ;)

* docker-compose: use keycloak 18 * feat: use kontinuous deployments * fix: fix logout flow * fix: realm export * fix: weborigins * fix: use secure password and prevent bruteforce * fix: FC secrets * fix: add NEXT_PUBLIC_APP_VERSION_COMMIT and NEXT_PUBLIC_IS_PRODUCTION_DEPLOYMENT * ci: add ks-review-deactivate * fix: dummy * fix: realm * docs * Update CODEOWNERS * fix: secrets * fix: log KC events * docs * fix: prod build args * fix: deactivate * fix: dummy

socket-security · 2022-06-16T20:11:30Z

Socket Security Report

📜 New install scripts detected

A dependency change in this PR is introducing new install scripts to your install step.

Package	Script field	Location
@sentry/cli@1.74.4 (upgraded)	`install`	`package.json` via @sentry/nextjs@6.19.7, @sentry/webpack-plugin@1.18.8

Socket.dev scan summary

Issue	Status
Did you mean?	✅ no new possible package typos
Install scripts	⚠️ 1 new install script detected
Telemetry	✅ no new telemetry
Troll package	✅ no new troll packages
Malware	✅ no new malware
Native code	✅ no new native modules

Powered by socket.dev

sonarcloud · 2022-06-16T20:36:27Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

No Coverage information
0.0% Duplication

github-actions · 2022-06-16T20:45:25Z

🎉 Deployment for commit 0f8453d :

Ingresses

Docker images

📦 docker pull harbor.fabrique.social.gouv.fr/fabrique/template/app:sha-0f8453d99f84fc3c67c402b60ffc900473bd1f3a

Debug

maxgfr added 3 commits April 8, 2022 15:08

fix: authentificatio

2150064

feat: add authentification page

d6d3f14

fix: merge

1257bc3

maxgfr requested a review from revolunet April 8, 2022 17:32

github-actions bot temporarily deployed to template-maxgfr-authentification-5fu0fu April 8, 2022 17:39 Inactive

fix: with auth

b7342ad

revolunet reviewed Apr 15, 2022

View reviewed changes

src/components/header/index.tsx Outdated Show resolved Hide resolved

maxgfr added 5 commits April 15, 2022 16:45

fix: use of next-auth

b0f9761

fix: env dev

6f0625b

fix: env development

eb68e58

fix: env

ecdcd12

Merge pull request #51 from SocialGouv/maxgfr/next-auth

55d8a90

fix: dep

99a59d7

maxgfr changed the title ~~feat(auth): add SSR authentification with keycloak~~ feat(auth): add authentification with keycloak Apr 22, 2022

maxgfr added 8 commits May 6, 2022 12:46

fix: bug

4afea53

fix: codeowner

40ccbf8

fix: keycloak

55aae65

fix: dockerfile etc

bc39902

fix: dockerfile etc

65df1ed

fix: dockerfile etc

15a0502

fix: dockerfile etc

afc4836

fix: dockerfile etc

903a315

revolunet reviewed May 8, 2022

View reviewed changes

src/lib/auth.ts Outdated Show resolved Hide resolved

maxgfr added 3 commits May 9, 2022 12:17

fix: simulation

eb30d43

fix: simulation

51d90a2

fix: simulation

802036f

maxgfr and others added 2 commits June 9, 2022 20:05

Update .github/workflows/production.yml

7332b77

Co-authored-by: Julien Bouquillon <julien.bouquillon@sg.social.gouv.fr>

Update .github/workflows/preproduction.yml

6688c6e

Co-authored-by: Julien Bouquillon <julien.bouquillon@sg.social.gouv.fr>

maxgfr and others added 2 commits June 9, 2022 20:06

Update .kube-workflow/values.yaml

ae1df9d

Co-authored-by: Julien Bouquillon <julien.bouquillon@sg.social.gouv.fr>

Update .github/workflows/review.yml

088830d

Co-authored-by: Julien Bouquillon <julien.bouquillon@sg.social.gouv.fr>

github-actions bot temporarily deployed to template-maxgfr-authentification-5fu0fu June 9, 2022 18:15 Inactive

maxgfr added 2 commits June 10, 2022 10:59

fix: retour

d463ba4

fix: docker

626373f

maxgfr requested a review from revolunet June 10, 2022 09:03

github-actions bot temporarily deployed to template-maxgfr-authentification-5fu0fu June 10, 2022 09:09 Inactive

revolunet reviewed Jun 10, 2022

View reviewed changes

.github/workflows/preproduction.yml Outdated Show resolved Hide resolved

Update .github/workflows/preproduction.yml

d234f73

Co-authored-by: Julien Bouquillon <julien.bouquillon@sg.social.gouv.fr>

revolunet reviewed Jun 10, 2022

View reviewed changes

.github/workflows/preproduction.yml Outdated Show resolved Hide resolved

revolunet reviewed Jun 10, 2022

View reviewed changes

.github/workflows/review.yml Outdated Show resolved Hide resolved

github-actions bot temporarily deployed to template-maxgfr-authentification-5fu0fu June 10, 2022 09:30 Inactive

fix: clean workflow

ff5a6ff

maxgfr requested a review from revolunet June 13, 2022 08:03

fix(ci): add get base host

f05903c

github-actions bot temporarily deployed to template-maxgfr-authentification-5fu0fu June 14, 2022 09:04 Inactive

docs: dummy

0f8453d

github-actions bot temporarily deployed to production June 16, 2022 20:44 Destroyed

revolunet approved these changes Jun 16, 2022

View reviewed changes

maxgfr merged commit 18b0bb4 into main Jun 17, 2022

maxgfr deleted the maxgfr/authentification branch June 17, 2022 09:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(auth): add authentification with keycloak #50

feat(auth): add authentification with keycloak #50

maxgfr commented Apr 8, 2022 •

edited

Loading

maxgfr commented Apr 8, 2022

revolunet commented Apr 15, 2022

gitguardian bot commented Apr 22, 2022

gitguardian bot commented Apr 22, 2022 •

edited

Loading

sonarcloud bot commented Jun 9, 2022

maxgfr commented Jun 10, 2022

maxgfr commented Jun 13, 2022

socket-security bot commented Jun 16, 2022

sonarcloud bot commented Jun 16, 2022

github-actions bot commented Jun 16, 2022

feat(auth): add authentification with keycloak #50

feat(auth): add authentification with keycloak #50

Conversation

maxgfr commented Apr 8, 2022 • edited Loading

DONE :

maxgfr commented Apr 8, 2022

revolunet commented Apr 15, 2022

gitguardian bot commented Apr 22, 2022

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

gitguardian bot commented Apr 22, 2022 • edited Loading

⚠️ GitGuardian has uncovered 14 secrets following the scan of your pull request.

sonarcloud bot commented Jun 9, 2022

maxgfr commented Jun 10, 2022

maxgfr commented Jun 13, 2022

socket-security bot commented Jun 16, 2022

Socket Security Report

sonarcloud bot commented Jun 16, 2022

github-actions bot commented Jun 16, 2022

maxgfr commented Apr 8, 2022 •

edited

Loading

gitguardian bot commented Apr 22, 2022 •

edited

Loading