Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split.sh seems not run #304

Closed
sinkcup opened this issue Apr 30, 2019 · 18 comments
Closed

split.sh seems not run #304

sinkcup opened this issue Apr 30, 2019 · 18 comments

Comments

@sinkcup
Copy link
Contributor

sinkcup commented Apr 30, 2019

new provider had been added to build/split.sh by PR #302

but new repo have not been auto created. 404: https://github.com/SocialiteProviders/WeChatServiceAccount

@sinkcup
Copy link
Contributor Author

sinkcup commented Apr 30, 2019

need your help. @m1guelpf

@sinkcup
Copy link
Contributor Author

sinkcup commented May 5, 2019

the repo is ok, then need to release a tag such as 1.0.0, then "submit repo as a package" on packagist.org @m1guelpf
now packages 404:
https://packagist.org/packages/socialiteproviders/wechat-web
https://packagist.org/packages/socialiteproviders/wechat-service-account

image

@LasseRafn
Copy link

Hi, I don't seem to have access to these

@sinkcup
Copy link
Contributor Author

sinkcup commented May 7, 2019

we need you. @m1guelpf

@sinkcup
Copy link
Contributor Author

sinkcup commented May 9, 2019

how are you? @m1guelpf

@sinkcup
Copy link
Contributor Author

sinkcup commented May 12, 2019

happy weekend, waiting your submit. @m1guelpf

@sinkcup
Copy link
Contributor Author

sinkcup commented May 14, 2019

maybe it's a good idea to set me as a owner of these two repos:
https://github.com/SocialiteProviders/WeChatServiceAccount
https://github.com/SocialiteProviders/WeChatWeb

so I can create tag and submit packagist. @m1guelpf

@sinkcup
Copy link
Contributor Author

sinkcup commented May 19, 2019

Hello, is there someone? @m1guelpf

@sinkcup
Copy link
Contributor Author

sinkcup commented May 20, 2019

hello? @m1guelpf

@sinkcup
Copy link
Contributor Author

sinkcup commented May 22, 2019

are you there? @m1guelpf

@m1guelpf
Copy link
Member

m1guelpf commented Jun 5, 2019

Hey! I'm really sorry about this. I've tagged and added the two repos to packagist.

@m1guelpf m1guelpf closed this as completed Jun 5, 2019
@sinkcup
Copy link
Contributor Author

sinkcup commented Jul 17, 2019

@m1guelpf, I had wait one month, it's too late, so I create a new org and repo: socialite providers, it can split and release tag automatically by CI.

https://github.com/laravel-socialite-providers/socialite-providers/blob/master/.circleci/config.yml

@m1guelpf
Copy link
Member

@sinkcup I'd love it if you could PR a version of that script to this org to keep everything updated ❤️

@sinkcup
Copy link
Contributor Author

sinkcup commented Jul 19, 2019

@m1guelpf, at first, I want to make a PR, but then I found this org and repo having some problems and some can not be fixed:

  1. github org URI and composer org URI don't follow slug style standard, it's difficult to read, you can see warnings in IDE or Chrome input box. the better URI is "github.com/socialite-providers" or https://github.com/laravel-socialite-providers

image

  1. repo and composer names are not semantic, it's unfriendly to fork. "socialite-providers/providers" is a bad name, the better one is "socialite-providers/socialite-providers"; "socialite-providers/stripe" is a bad name, the better one is "socialite-providers/socialite-stripe". see repo name is not semantic laravel-fans/socialite-providers#9

  2. Documents are not in code, it's difficult to make PR. If I want to add one provider, but I need to fork two repo... so I use readme.md in code, and use a script to convert them to gh-pages as docs. see https://github.com/laravel-socialite-providers/socialite-providers/blob/master/build-docs.sh

@LasseRafn Do you have any advice?

@m1guelpf
Copy link
Member

@sinkcup I see how other names would be better but I'm afraid this organization has been around for too long to just change this. Also, renaming packages would be a breaking change. I'm fine with managing the docs myself (as that's done by Netlify) and maintaining a reference that joins paths and repos (maybe a JSON version of the split.sh file? My issue is with having to re-run manually the split script in my computer every time a new commit is merged, as it can take me quite some time.

@sinkcup
Copy link
Contributor Author

sinkcup commented Jul 19, 2019

@m1guelpf, you are right, we can't change a wildly used package's name.

I have a suggestion: keep this org and repo only for reading, we use "github.com/socialite-providers" or https://github.com/laravel-socialite-providers as a new begin, and format providers and docs to the new repo.

split and tag can be automatical, but packagist.org doesn't support submit a package by API, so we need to submit when each new package merged, it will take a little time. we can all be admin, It's really difficult for a person to handle it in time.

@m1guelpf
Copy link
Member

Hmmm, I'd like to preserve stats if possible. Let me contact packagiat support to ask if there's a better way of managing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants