Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is offset typed as "chrono_t long _offset" ? #20

Open
sofian opened this issue Mar 12, 2024 · 4 comments
Open

Why is offset typed as "chrono_t long _offset" ? #20

sofian opened this issue Mar 12, 2024 · 4 comments
Assignees
Labels

Comments

@sofian
Copy link
Collaborator

sofian commented Mar 12, 2024

Seems like a mistake. It should just be "chrono_t" (?)

@sofian sofian changed the title Why is offset typed as "chrono_t long _offset;" ? Why is offset typed as "chrono_t long _offset" ? Mar 12, 2024
@thomasfredericks
Copy link
Collaborator

Probably an error. I am surprised the compiler did not pick it up as a warning...

@sofian
Copy link
Collaborator Author

sofian commented Mar 12, 2024

In fact, I think it creates an unsigned long long int which is probably something like a 64 bits integer :-P

@sofian sofian added bug and removed question labels Mar 12, 2024
@sofian sofian self-assigned this Mar 12, 2024
@sofian
Copy link
Collaborator Author

sofian commented Mar 12, 2024

It is possible that what was meant originally here was to have a signed long integer in order to be able to add a negative offset. Is this something that would be needed?

@sofian
Copy link
Collaborator Author

sofian commented Mar 12, 2024

Looking back at the code ... I'm not even sure we need to have a separate variable offset to manage offsets, cause we might be able to do everything with the _startTime variable. I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants